----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21174/#review42665 -----------------------------------------------------------
core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala <https://reviews.apache.org/r/21174/#comment76489> Should we do assertTrue(scheduler.failed == false) again after shutting down the scheduler? core/src/test/scala/unit/kafka/utils/TestUtils.scala <https://reviews.apache.org/r/21174/#comment76488> Since this method should always return a valid leader (or an exception will be thrown), should we just return Int, instead of Option[Int]? - Jun Rao On May 9, 2014, 5:35 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21174/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 5:35 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1396 > https://issues.apache.org/jira/browse/KAFKA-1396 > > > Repository: kafka > > > Description > ------- > > Address Jun's comments round two > > > Diffs > ----- > > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala > a993e8c7531abca6b82d1718ac57ba6a295c1fc7 > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala > af11a4983599a20a33b6f1fc05738a59abfede63 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 034f36130a1d0669dda5ed53e9cee328806c811e > > Diff: https://reviews.apache.org/r/21174/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
