Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- (Updated April 25, 2014, 9:09 p.m.) Review request for kafka. Bugs: KAFKA-139

Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review41521 --- Looks good. Just the following minor comment. core/src/test/scala/

Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- (Updated April 25, 2014, 6:03 p.m.) Review request for kafka. Bugs: KAFKA-139

Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review41472 --- Great cleanup patch! Some minor comments. 1. TestUtils.createProdu

Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- (Updated April 24, 2014, 11:22 p.m.) Review request for kafka. Summary (updat

Re: Review Request 20380: Fix KAFKA-1395: incorporate Neha's comment, ensure createProducer use ack = -1 and type = async, with configurable serializer and partitioner

> On April 22, 2014, 10 p.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala, lines > > 114-116 > > > > > > For this particular test, resending in the producer could introduce

Re: Review Request 20380: Fix KAFKA-1395: incorporate Neha's comment, ensure createProducer use ack = -1 and type = async, with configurable serializer and partitioner

> On April 22, 2014, 10 p.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala, lines > > 114-116 > > > > > > For this particular test, resending in the producer could introduce

Re: Review Request 20380: Fix KAFKA-1395: incorporate Neha's comment, ensure createProducer use ack = -1 and type = async, with configurable serializer and partitioner

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review41070 --- core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scal

Re: Review Request 20380: Fix KAFKA-1395: incorporate Neha's comment, ensure createProducer use ack = -1 and type = async, with configurable serializer and partitioner

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- (Updated April 22, 2014, 5:43 p.m.) Review request for kafka. Summary (update

Re: Review Request 20380: Fix KAFKA-1395: incorporate Jun's comment

> On April 21, 2014, 10:11 p.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala, line > > 122 > > > > > > Is this check for metadata propagation actually required? It see

Re: Review Request 20380: Fix KAFKA-1395: incorporate Jun's comment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review40972 --- core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scal

Re: Review Request 20380: Fix KAFKA-1395: incorporate Jun's comment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- (Updated April 16, 2014, 5:11 p.m.) Review request for kafka. Summary (update

Re: Review Request 20380: Fix KAFKA-1395

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review40551 --- core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scal

Review Request 20380: Fix KAFKA-1395

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- Review request for kafka. Bugs: KAFKA-1395 https://issues.apache.org/jira/b