Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Jun Rao
> On April 23, 2014, 9:56 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/admin/AdminTest.scala, line 313 > > > > > > Also line 292, 249, 207, 179, 150, 133, 123 Since these tests don't produce messages,

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/#review41241 --- Ship it! Ship It! - Neha Narkhede On April 23, 2014, 9:36 p.m.,

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/#review41220 --- core/src/test/scala/unit/kafka/admin/AdminTest.scala

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/ --- (Updated April 23, 2014, 9:36 p.m.) Review request for kafka. Bugs: KAFKA-138

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/#review41216 --- Ship it! Ship It! - Guozhang Wang On April 23, 2014, 5:41 p.m.,

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/#review41213 --- Ship it! Ship It! - Neha Narkhede On April 23, 2014, 5:41 p.m.,

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Jun Rao
> On April 14, 2014, 5:43 a.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/utils/TestUtils.scala, line 151 > > > > > > Actually, do we need waitUntilMetadataIsPropogated here? Shall we just > > remove lin

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/ --- (Updated April 23, 2014, 5:41 p.m.) Review request for kafka. Bugs: KAFKA-138

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/#review40247 --- core/src/test/scala/unit/kafka/utils/TestUtils.scala

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-13 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/#review40231 --- core/src/test/scala/unit/kafka/utils/TestUtils.scala

Review Request 20290: Patch for KAFKA-1389

2014-04-13 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/ --- Review request for kafka. Bugs: KAFKA-1389 https://issues.apache.org/jira/b