-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20290/
-----------------------------------------------------------
(Updated April 23, 2014, 9:36 p.m.)
Review request for kafka.
Bugs: KAFKA-1389
https://issues.apache.org/jira/browse/KAFKA-1389
Repository: kafka
Description (updated)
-------
4. Replace ad hoc createOrUpdateTopicPartitionAssignmentPathInZK with
TestUtils.createTopic(). 5. Remove ad hoc timeout in
waitUntilMetadataIsPropagated in a few remaining places.
3. Increase the default timeout in waitUntilMetadataIsPropagated to 5 secs.
1. Standardize all topic creation that need to wait leader election and
metadata propagation using TestUtils.createTopic(). 2. Fix a few warnings in
compilation.
Diffs (updated)
-----
core/src/main/scala/kafka/admin/TopicCommand.scala
686a0dfc65b036263375db7f64f1f2bae42199b0
core/src/main/scala/kafka/controller/ControllerChannelManager.scala
c95c650cffbeed27e837e7c2d628f9026feb2c17
core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
a64946108049e7d15f655208a2bc6cabcb1e8720
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala
440aed828513c7f940612a25aa4b5fac6348f07d
core/src/test/scala/unit/kafka/admin/AdminTest.scala
8991050ece090f3d7558eb69b0bf7d450e7ecd5c
core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala
965099afec451e34136841072c9c07c918e84729
core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala
e93305a8692c59c211b4c510b07cd193ccdab69a
core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala
1415773dc34d2111eb923eee812b6dc89a353441
core/src/test/scala/unit/kafka/integration/FetcherTest.scala
9e1a3b76fe118737172debb6e530e6c8863f671e
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala
60a466ff5de78bc4443ec49307b6f214d028b9d2
core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala
334615615c91ad01934e115f28166539ffab3a19
core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala
761f759a8b771dbdc3b552011fdac6f407bdd3ae
core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala
1bf9462387897e5ad90530a35341a7320993ab29
core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala
bdc6f01f2e2d8e9604cd8f786a6423fd45dc543d
core/src/test/scala/unit/kafka/producer/ProducerTest.scala
439e33e77e6ff317307612dbb5facf026493b31e
core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala
4840824cc2af05ecd6b811c307b5a0625b2b3e52
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala
5136fbee8462eb15a94ce13de75cb97967fd2662
core/src/test/scala/unit/kafka/server/LogOffsetTest.scala
76ae6595953695212eca64b0ddda8a8c15d8ce11
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala
ddb24029570329ff9528ea509528b85a5852dab4
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala
90c21c6966e3b34b5f687231bfc307788dc28e0f
core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala
5305167abf2b2a10ba91d6897f23e70466fefeba
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala
1651822f60883e3bb17c75c9b0353ffff00bbd6c
core/src/test/scala/unit/kafka/utils/TestUtils.scala
4bd59645635cb693de3a638e58ef19363eb742e5
Diff: https://reviews.apache.org/r/20290/diff/
Testing
-------
Thanks,
Jun Rao
