> On April 14, 2014, 5:43 a.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/utils/TestUtils.scala, line 151 > > <https://reviews.apache.org/r/20290/diff/1/?file=555687#file555687line151> > > > > Actually, do we need waitUntilMetadataIsPropogated here? Shall we just > > remove line 151 and set timeout to 500 in waitUntilLeaderIsElected in 152?
Leader info is not propagated to all brokers and metadata is propagated to all brokers. To really make sure a send can succeed, we need to make sure the leader is ready and the metadata in up to date in all brokers. - Jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/#review40247 ----------------------------------------------------------- On April 23, 2014, 5:41 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20290/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 5:41 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1389 > https://issues.apache.org/jira/browse/KAFKA-1389 > > > Repository: kafka > > > Description > ------- > > 3. Increase the default timeout in waitUntilMetadataIsPropagated to 5 secs. > > > 1. Standardize all topic creation that need to wait leader election and > metadata propagation using TestUtils.createTopic(). 2. Fix a few warnings in > compilation. > > > Diffs > ----- > > core/src/main/scala/kafka/admin/TopicCommand.scala > 686a0dfc65b036263375db7f64f1f2bae42199b0 > core/src/main/scala/kafka/controller/ControllerChannelManager.scala > c95c650cffbeed27e837e7c2d628f9026feb2c17 > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala > a64946108049e7d15f655208a2bc6cabcb1e8720 > core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala > 440aed828513c7f940612a25aa4b5fac6348f07d > core/src/test/scala/unit/kafka/admin/AdminTest.scala > 8991050ece090f3d7558eb69b0bf7d450e7ecd5c > > core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala > e93305a8692c59c211b4c510b07cd193ccdab69a > core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala > 1415773dc34d2111eb923eee812b6dc89a353441 > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala > 60a466ff5de78bc4443ec49307b6f214d028b9d2 > core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala > 761f759a8b771dbdc3b552011fdac6f407bdd3ae > core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala > bdc6f01f2e2d8e9604cd8f786a6423fd45dc543d > core/src/test/scala/unit/kafka/producer/ProducerTest.scala > 439e33e77e6ff317307612dbb5facf026493b31e > core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala > 4840824cc2af05ecd6b811c307b5a0625b2b3e52 > core/src/test/scala/unit/kafka/server/LogOffsetTest.scala > 76ae6595953695212eca64b0ddda8a8c15d8ce11 > core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala > 5305167abf2b2a10ba91d6897f23e70466fefeba > core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala > 1651822f60883e3bb17c75c9b0353ffff00bbd6c > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 4bd59645635cb693de3a638e58ef19363eb742e5 > > Diff: https://reviews.apache.org/r/20290/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
