Re: Review Request 19696: Patch for KAFKA-1317

2014-03-28 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19696/#review38941 --- core/src/main/scala/kafka/controller/TopicDeletionManager.scala

Re: Review Request 19696: Patch for KAFKA-1317

2014-03-28 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19696/#review38902 --- Ship it! Looks great, thanks! core/src/main/scala/kafka/controlle

Re: Review Request 19696: Patch for KAFKA-1317

2014-03-28 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19696/ --- (Updated March 28, 2014, 4:34 p.m.) Review request for kafka. Bugs: KAFKA-131

Re: Review Request 19696: Patch for KAFKA-1317

2014-03-27 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19696/#review38870 --- core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala <

Re: Review Request 19696: Patch for KAFKA-1317

2014-03-27 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19696/ --- (Updated March 27, 2014, 10:15 p.m.) Review request for kafka. Bugs: KAFKA-13

Re: Review Request 19696: Patch for KAFKA-1317

2014-03-26 Thread Timothy Chen
> On March 26, 2014, 10:59 p.m., Neha Narkhede wrote: > > When I applied this patch to trunk, I started seeing unit test failures. In > > my last test run, kafka.log4j.KafkaLog4jAppenderTest fails. Before this, > > I've never seen unit test failures, so I wonder if this patch is causing > > th

Re: Review Request 19696: Patch for KAFKA-1317

2014-03-26 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19696/#review38670 --- When I applied this patch to trunk, I started seeing unit test failu

Re: Review Request 19696: Patch for KAFKA-1317

2014-03-26 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19696/ --- (Updated March 26, 2014, 10:19 p.m.) Review request for kafka. Bugs: KAFKA-13

Re: Review Request 19696: Patch for KAFKA-1317

2014-03-26 Thread Neha Narkhede
> On March 26, 2014, 7:16 p.m., Neha Narkhede wrote: > > Tim, > > > > I get the following conflict when I try to apply this patch to the 0.8.1 > > branch - > > > > nnarkhed-mn1:kafka-git-idea nnarkhed$ patch -p1 -i > > ~/Projects/kafka-patches/kafka-1317-march26.patch > > patching file core/

Re: Review Request 19696: Patch for KAFKA-1317

2014-03-26 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19696/#review38648 --- Tim, I get the following conflict when I try to apply this patch to

Re: Review Request 19696: Patch for KAFKA-1317

2014-03-26 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19696/ --- (Updated March 26, 2014, 6:59 p.m.) Review request for kafka. Bugs: KAFKA-131

Review Request 19696: Patch for KAFKA-1317

2014-03-26 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19696/ --- Review request for kafka. Bugs: KAFKA-1317 https://issues.apache.org/jira/b