Re: Review Request 16718: Patch for KAFKA-1180

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/#review47480 --- Ship it! Looks good apart from the minor comment I had on the tests

Re: Review Request 16718: Patch for KAFKA-1180

> On Feb. 13, 2014, 10:54 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/utils/Utils.scala, line 545 > > > > > > Thanks for the comment. However, I still don't get it. Why are JSON > > strings > > relevant

Re: Review Request 16718: Patch for KAFKA-1180

> On Feb. 13, 2014, 10:54 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/utils/Utils.scala, line 545 > > > > > > Thanks for the comment. However, I still don't get it. Why are JSON > > strings > > relevant

Re: Review Request 16718: Patch for KAFKA-1180

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/#review34433 --- core/src/main/scala/kafka/utils/Utils.scala

Re: Review Request 16718: Patch for KAFKA-1180

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/#review34422 --- Ship it! Ship It! - Guozhang Wang On Feb. 13, 2014, 8:24 p.m., J

Re: Review Request 16718: Patch for KAFKA-1180

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/ --- (Updated Feb. 13, 2014, 8:24 p.m.) Review request for kafka. Bugs: KAFKA-1180

Re: Review Request 16718: Patch for KAFKA-1180

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/ --- (Updated Feb. 13, 2014, 8:21 p.m.) Review request for kafka. Bugs: KAFKA-1180

Re: Review Request 16718: Patch for KAFKA-1180

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/ --- (Updated Feb. 13, 2014, 8:16 p.m.) Review request for kafka. Bugs: KAFKA-1180

Re: Review Request 16718: Patch for KAFKA-1180

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/ --- (Updated Feb. 13, 2014, 8:13 p.m.) Review request for kafka. Bugs: KAFKA-1180

Re: Review Request 16718: Patch for KAFKA-1180

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/ --- (Updated Feb. 13, 2014, 7:50 p.m.) Review request for kafka. Bugs: KAFKA-1180

Re: Review Request 16718: Patch for KAFKA-1180

> On Feb. 10, 2014, 10:58 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala, line 45 > > > > > > Just caught my eye: this does not test anything right? It was like that before

Re: Review Request 16718: Patch for KAFKA-1180

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/#review34128 --- Ship it! core/src/test/scala/unit/kafka/consumer/TopicFilterTest.s

Re: Review Request 16718: Patch for KAFKA-1180

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/ --- (Updated Feb. 10, 2014, 1:21 a.m.) Review request for kafka. Bugs: KAFKA-1180

Re: Review Request 16718: Patch for KAFKA-1180

> On Jan. 8, 2014, 2:49 a.m., joel koshy wrote: > > core/src/main/scala/kafka/utils/Utils.scala, line 544 > > > > > > Thanks for patching this issue. > > > > I'm not very clear on the cases here - i.e., is it

Re: Review Request 16718: Patch for KAFKA-1180

> On Jan. 8, 2014, 2:49 a.m., joel koshy wrote: > > core/src/main/scala/kafka/utils/Utils.scala, line 544 > > > > > > Thanks for patching this issue. > > > > I'm not very clear on the cases here - i.e., is it

Re: Review Request 16718: Patch for KAFKA-1180

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/#review31336 --- core/src/main/scala/kafka/utils/Utils.scala

Review Request 16718: Patch for KAFKA-1180

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/ --- Review request for kafka. Bugs: KAFKA-1180 https://issues.apache.org/jira/b