> On Feb. 10, 2014, 10:58 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala, line 45 > > <https://reviews.apache.org/r/16718/diff/2/?file=481264#file481264line45> > > > > Just caught my eye: this does not test anything right?
It was like that before, let me add some more tests on it so it does something moving forward, yup - Joe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/#review34128 ----------------------------------------------------------- On Feb. 10, 2014, 1:21 a.m., Joe Stein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16718/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2014, 1:21 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1180 > https://issues.apache.org/jira/browse/KAFKA-1180 > > > Repository: kafka > > > Description > ------- > > KAFKA-1180 WhiteList topic filter gets a NullPointerException on complex Regex > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/TopicCount.scala > e33263378489f7cb5ba98476a8e6d65640130965 > core/src/main/scala/kafka/utils/Utils.scala > a89b0463685e6224d263bc9177075e1bb6b93d04 > core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala > cf2724bb68d39256f033687c25cde24c667c3d8d > > Diff: https://reviews.apache.org/r/16718/diff/ > > > Testing > ------- > > > Thanks, > > Joe Stein > >
