----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/#review34433 -----------------------------------------------------------
core/src/main/scala/kafka/utils/Utils.scala <https://reviews.apache.org/r/16718/#comment64525> Thanks for the comment. However, I still don't get it. Why are JSON strings relevant here? i.e., we are ultimately dealing with a Java regex in the TopicFilter. I'm sure your patch works (as verified by Jason), but I can't say I understand this. core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala <https://reviews.apache.org/r/16718/#comment64526> Do we actually need this test? i.e., my thinking was that we could just add the escaped cases to the whitelist/blacklist tests above - including the specific failure case that Jason reported. - Joel Koshy On Feb. 13, 2014, 8:24 p.m., Joe Stein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16718/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 8:24 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1180 > https://issues.apache.org/jira/browse/KAFKA-1180 > > > Repository: kafka > > > Description > ------- > > KAFKA-1180 WhiteList topic filter gets a NullPointerException on complex > Regex and added Blacklist test that was missing > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/TopicCount.scala > e33263378489f7cb5ba98476a8e6d65640130965 > core/src/main/scala/kafka/utils/Utils.scala > a89b0463685e6224d263bc9177075e1bb6b93d04 > core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala > cf2724bb68d39256f033687c25cde24c667c3d8d > > Diff: https://reviews.apache.org/r/16718/diff/ > > > Testing > ------- > > > Thanks, > > Joe Stein > >
