Re: Review Request 15901: Patch for KAFKA-1152

2013-12-02 Thread Swapnil Ghike
> On Dec. 2, 2013, 5:06 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 358 > > > > > > the check should probably be leaderId >= 0. The "leaders" in the > > LeaderAndIsrReque

Re: Review Request 15901: Patch for KAFKA-1152

2013-12-02 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15901/#review29588 --- core/src/main/scala/kafka/server/ReplicaManager.scala

Re: Review Request 15901: Patch for KAFKA-1152

2013-11-28 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15901/ --- (Updated Nov. 29, 2013, 6:41 a.m.) Review request for kafka. Bugs: KAFKA-1152

Re: Review Request 15901: Patch for KAFKA-1152

2013-11-28 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15901/#review29554 --- core/src/main/scala/kafka/server/ReplicaManager.scala

Re: Review Request 15901: Patch for KAFKA-1152

2013-11-28 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15901/ --- (Updated Nov. 28, 2013, 6:19 p.m.) Review request for kafka. Summary (updated