----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15901/#review29554 -----------------------------------------------------------
core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/15901/#comment56906> Could we use case match here? Then, we don't need to call leaders.find() again. core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/15901/#comment56904> Could we use map.put() since it's used in other places? core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/15901/#comment56905> The ordering of leader and partition is incorrect. - Jun Rao On Nov. 28, 2013, 6:19 p.m., Swapnil Ghike wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15901/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2013, 6:19 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1152 > https://issues.apache.org/jira/browse/KAFKA-1152 > > > Repository: kafka > > > Description > ------- > > ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle > leader == -1 > > > Diffs > ----- > > core/src/main/scala/kafka/server/ReplicaManager.scala > 161f58134f20f9335dbd2bee6ac3f71897cbef7c > > Diff: https://reviews.apache.org/r/15901/diff/ > > > Testing > ------- > > Builds with all scala versions; unit tests pass > > > Thanks, > > Swapnil Ghike > >
