Re: Review Request 36578: Patch for KAFKA-2338

2015-09-14 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/#review98911 --- core/src/main/scala/kafka/admin/TopicCommand.scala (line 92)

Re: Review Request 36578: Patch for KAFKA-2338

2015-09-03 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/#review97668 --- Thanks for the patch. A couple of comments below. core/src/main/sc

Re: Review Request 36578: Patch for KAFKA-2338

2015-09-02 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/ --- (Updated Sept. 2, 2015, 10:30 p.m.) Review request for kafka. Bugs: KAFKA-233

Re: Review Request 36578: Patch for KAFKA-2338

2015-08-24 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/ --- (Updated Aug. 24, 2015, 5:36 p.m.) Review request for kafka. Bugs: KAFKA-2338

Re: Review Request 36578: Patch for KAFKA-2338

2015-08-20 Thread Manikumar Reddy O
On Aug. 20, 2015, 11:07 a.m., Edward Ribeiro wrote: > > Also do want to include patch for second point given in JIRA decription.. just read previous reviews..ignore my comment. - Manikumar Reddy --- This is an automatically generated e-

Re: Review Request 36578: Patch for KAFKA-2338

2015-08-20 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/#review95943 --- core/src/main/scala/kafka/admin/TopicCommand.scala (line 89)

Re: Review Request 36578: Patch for KAFKA-2338

2015-07-21 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/#review92526 --- core/src/main/scala/kafka/server/AbstractFetcherThread.scala (line

Re: Review Request 36578: Patch for KAFKA-2338

2015-07-21 Thread Edward Ribeiro
> On July 21, 2015, 6:57 a.m., Ewen Cheslack-Postava wrote: > > core/src/main/scala/kafka/admin/TopicCommand.scala, line 90 > > > > > > This format call isn't working because it's being called on the second > > strin

Re: Review Request 36578: Patch for KAFKA-2338

2015-07-21 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/ --- (Updated July 21, 2015, 4:21 p.m.) Review request for kafka. Bugs: KAFKA-2338

Re: Review Request 36578: Patch for KAFKA-2338

2015-07-20 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/#review92374 --- In addition to inline comments, the patch fell out of sync recently

Re: Review Request 36578: Patch for KAFKA-2338

2015-07-17 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/ --- (Updated July 18, 2015, 3:37 a.m.) Review request for kafka. Bugs: KAFKA-2338

Re: Review Request 36578: Patch for KAFKA-2338

2015-07-17 Thread Edward Ribeiro
> On July 18, 2015, 12:10 a.m., Ashish Singh wrote: > > core/src/main/scala/kafka/admin/TopicCommand.scala, lines 56-62 > > > > > > Nit: What changed here? Its always a good idea to keep non-functional > > changes ve

Re: Review Request 36578: Patch for KAFKA-2338

2015-07-17 Thread Edward Ribeiro
> On July 18, 2015, 12:10 a.m., Ashish Singh wrote: > > core/src/main/scala/kafka/admin/TopicCommand.scala, line 87 > > > > > > I guess it is unnecessary to parse "0" as int. You can have > > maxMessageSize init to 0

Re: Review Request 36578: Patch for KAFKA-2338

2015-07-17 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/#review92145 --- core/src/main/scala/kafka/admin/TopicCommand.scala (lines 56 - 62)