----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/#review98911 -----------------------------------------------------------
core/src/main/scala/kafka/admin/TopicCommand.scala (line 92) <https://reviews.apache.org/r/36578/#comment155621> Sure! Going to address this. core/src/main/scala/kafka/server/AbstractFetcherThread.scala (lines 176 - 178) <https://reviews.apache.org/r/36578/#comment155622> Cool! Thanks for the heads up! Gonna get rid of this useless catch and modify accordingly. - Edward Ribeiro On Sept. 2, 2015, 10:30 p.m., Edward Ribeiro wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36578/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 10:30 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2338 > https://issues.apache.org/jira/browse/KAFKA-2338 > > > Repository: kafka > > > Description > ------- > > KAFKA-2338 Warn users if they change max.message.bytes that they also need to > update broker and consumer settings > > > Diffs > ----- > > core/src/main/scala/kafka/admin/TopicCommand.scala > f1405a5b2961bc826caa22507db8ba39ce1cf4d3 > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > dca975ca1bf3e560b9d9817e7f2a511ef4296e70 > > Diff: https://reviews.apache.org/r/36578/diff/ > > > Testing > ------- > > > Thanks, > > Edward Ribeiro > >
