----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/#review92526 -----------------------------------------------------------
core/src/main/scala/kafka/server/AbstractFetcherThread.scala (line 166) <https://reviews.apache.org/r/36578/#comment146731> Well, 2 things. First, I only took a quick look after I couldn't reproduce the issue, so I could have missed an error code that can be returned and which *would* allow us to issue a warning here. Second, the other warning is still useful. If users start to see stalls in their consumer, they may start looking at consumer logs, but eventually it will make sense to look at the brokers as well. And for the replication failure, they're likely to look at all the brokers for the given partition. Providing help *anywhere* is much better than the current situation of just silently stalling. - Ewen Cheslack-Postava On July 21, 2015, 4:21 p.m., Edward Ribeiro wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36578/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 4:21 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2338 > https://issues.apache.org/jira/browse/KAFKA-2338 > > > Repository: kafka > > > Description > ------- > > KAFKA-2338 Warn users if they change max.message.bytes that they also need to > update broker and consumer settings > > > Diffs > ----- > > core/src/main/scala/kafka/admin/TopicCommand.scala > 4e28bf1c08414e8e96e6ca639b927d51bfeb4616 > > Diff: https://reviews.apache.org/r/36578/diff/ > > > Testing > ------- > > > Thanks, > > Edward Ribeiro > >
