Re: Review Request 30196: Patch for KAFKA-1886

2015-05-04 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30196/#review82408 --- Ship it! Ship It! - Neha Narkhede On April 28, 2015, 5:28 p.m.,

Re: Review Request 30196: Patch for KAFKA-1886

2015-04-28 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30196/ --- (Updated April 28, 2015, 5:28 p.m.) Review request for kafka and Joel Koshy.

Re: Review Request 30196: Patch for KAFKA-1886

2015-04-28 Thread Aditya Auradkar
> On Feb. 7, 2015, 4:22 p.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 295 > > > > > > Why do you need the sleep here? We try to avoid blindly sleeping in > > Ka

Re: Review Request 30196: Patch for KAFKA-1886

2015-04-28 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30196/ --- (Updated April 28, 2015, 5:27 p.m.) Review request for kafka and Joel Koshy.

Re: Review Request 30196: Patch for KAFKA-1886

2015-04-26 Thread Neha Narkhede
> On Feb. 7, 2015, 4:22 p.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 295 > > > > > > Why do you need the sleep here? We try to avoid blindly sleeping in > > Ka

Re: Review Request 30196: Patch for KAFKA-1886

2015-02-23 Thread Aditya Auradkar
> On Feb. 7, 2015, 4:22 p.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 295 > > > > > > Why do you need the sleep here? We try to avoid blindly sleeping in > > Ka

Re: Review Request 30196: Patch for KAFKA-1886

2015-02-08 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30196/#review71556 --- core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala <

Re: Review Request 30196: Patch for KAFKA-1886

2015-02-02 Thread Aditya Auradkar
> On Jan. 26, 2015, 1:28 a.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 235 > > > > > > what is the purpose of this sleep? > > Aditya Auradkar wrote: > I wan

Re: Review Request 30196: Patch for KAFKA-1886

2015-02-02 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30196/ --- (Updated Feb. 2, 2015, 9:57 p.m.) Review request for kafka and Joel Koshy. Bu

Re: Review Request 30196: Patch for KAFKA-1886

2015-01-26 Thread Aditya Auradkar
> On Jan. 26, 2015, 1:28 a.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 235 > > > > > > what is the purpose of this sleep? I wanted to make sure the SimpleConsum

Re: Review Request 30196: Patch for KAFKA-1886

2015-01-25 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30196/#review69579 --- core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala <

Re: Review Request 30196: Patch for KAFKA-1886

2015-01-22 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30196/ --- (Updated Jan. 22, 2015, 10:35 p.m.) Review request for kafka and Joel Koshy.