> On Jan. 26, 2015, 1:28 a.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 235 > > <https://reviews.apache.org/r/30196/diff/1/?file=831148#file831148line235> > > > > what is the purpose of this sleep?
I wanted to make sure the SimpleConsumer was making a request to the broker when I interrupted. I can reduce the sleep time to 100ms if that helps. - Aditya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30196/#review69579 ----------------------------------------------------------- On Jan. 22, 2015, 10:35 p.m., Aditya Auradkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30196/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 10:35 p.m.) > > > Review request for kafka and Joel Koshy. > > > Bugs: KAFKA-1886 > https://issues.apache.org/jira/browse/KAFKA-1886 > > > Repository: kafka > > > Description > ------- > > Fixing KAFKA-1886. Forcing the SimpleConsumer to throw a > ClosedByInterruptException if thrown and not retry > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > trunk > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/SimpleConsumer.scala > cbef84ac76e62768981f74e71d451f2bda995275 > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala > a5386a03b62956bc440b40783247c8cdf7432315 > > Diff: https://reviews.apache.org/r/30196/diff/ > > > Testing > ------- > > Added an integration test to PrimitiveAPITest.scala. > > > Thanks, > > Aditya Auradkar > >
