Re: Review Request 15201: address previous review comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15201/#review28715 --- Ship it! Ship It! - Guozhang Wang On Nov. 11, 2013, 4:44 p.m., J

Re: Review Request 15201: address previous review comments

Hi Administrators, Can you help me get out of this email-dlist? I do not see any URL to unsubscribe. thanks manoj On 11/11/2013 11:06 AM, Neha Narkhede wrote: --- This is an automatically generated e-mail. To reply, visit: https://revi

Re: Review Request 15201: address previous review comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15201/#review28665 --- core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala

Re: Review Request 15201: address previous review comments

> On Nov. 5, 2013, 6:27 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala, line 247 > > > > > > map{ -> map { > > Jun Rao wrote: > Not sure this is the standard. We do ma

Re: Review Request 15201: address previous review comments

> On Nov. 5, 2013, 10:41 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala, line 73 > > > > > > We do not need () after withRequiredArg here. done > On Nov. 5, 2013, 10:41 p

Re: Review Request 15201: address previous review comments

> On Nov. 5, 2013, 6:27 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala, line 66 > > > > > > Default max.message.size is (1MB + header). Default fetch size should > > be a l

Re: Review Request 15201: address previous review comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15201/ --- (Updated Nov. 11, 2013, 4:44 p.m.) Review request for kafka. Summary (updated