Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/ --- (Updated Sept. 16, 2013, 9:40 p.m.) Review request for kafka. Bugs: KAFKA-105

Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/#review26141 --- Ship it! Ship It! - Swapnil Ghike On Sept. 16, 2013, 3:28 a.m.,

Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/#review26140 --- kafka-patch-review.py

Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/ --- (Updated Sept. 16, 2013, 3:28 a.m.) Review request for kafka. Bugs: KAFKA-105

Re: Review Request 14091: Patch for KAFKA-1053

> On Sept. 14, 2013, 7:07 p.m., Swapnil Ghike wrote: > > kafka-patch-review.py, lines 50-51 > > > > > > Do you intend to save the patch file in current directory? I wonder if > > we should delete it, because it is mor

Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/ --- (Updated Sept. 15, 2013, 4:40 p.m.) Review request for kafka. Bugs: KAFKA-105

Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/#review26115 --- kafka-patch-review.py

Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/ --- (Updated Sept. 13, 2013, 11:33 p.m.) Review request for kafka. Bugs: KAFKA-10

Re: Review Request 14091: Patch for KAFKA-1053

> On Sept. 13, 2013, 10:48 p.m., Sriram Subramanian wrote: > > Might be useful to publish it widely Makes sense. I just got pinged by Helix, they want to use the tool. Probably publishing it on github will be useful to a lot of projects. Thanks! - Neha -

Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/#review26109 --- Might be useful to publish it widely - Sriram Subramanian On Sept

Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/#review26108 --- Ship it! Ship It! - Sriram Subramanian On Sept. 13, 2013, 10:34

Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/ --- (Updated Sept. 13, 2013, 10:34 p.m.) Review request for kafka. Bugs: KAFKA-10

Re: Review Request 14091: Patch for KAFKA-1053

> On Sept. 13, 2013, 4:58 p.m., Guozhang Wang wrote: > > kafka-patch-review.py, line 43 > > > > > > If version is not specified, then v1 is used as default: I think this > > might mess up the ticket attachments from mu

Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/#review26082 --- kafka-patch-review.py

Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/ --- (Updated Sept. 12, 2013, 9:23 p.m.) Review request for kafka. Bugs: KAFKA-105

Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/ --- (Updated Sept. 12, 2013, 9:22 p.m.) Review request for kafka. Summary (update