> On Sept. 13, 2013, 4:58 p.m., Guozhang Wang wrote: > > kafka-patch-review.py, line 43 > > <https://reviews.apache.org/r/14091/diff/9/?file=351276#file351276line43> > > > > If version is not specified, then v1 is used as default: I think this > > might mess up the ticket attachments from multiple RBs if people just > > forgot to use -v command. Does jira have getting attachment cmd so we can > > read the file names and automatically figure out the versions? If not we > > can at least force -v to be required and then if -r is not set ignore this > > parameter.
That is a very good suggestion. Will upload another patch with this fixed. - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/#review26082 ----------------------------------------------------------- On Sept. 12, 2013, 9:23 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14091/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2013, 9:23 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1053 > https://issues.apache.org/jira/browse/KAFKA-1053 > > > Repository: kafka > > > Description > ------- > > Changed the script to use the jira-python package > > > Diffs > ----- > > .reviewboardrc PRE-CREATION > kafka-patch-review.py PRE-CREATION > > Diff: https://reviews.apache.org/r/14091/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
