Re: [VOTE] KIP-979 Allow independently stop KRaft processes

2023-11-17 Thread Hailey Ni
Hi everyone, With +3 binding votes (and +2 non-binding), the vote passes. *KIP-979* Allow independently stop KRaft processes is Adopted! Thank you all for your reviews and votes. Regards, Hailey On Fri, Nov 17, 2023 at 12:43 PM Hailey Ni wrote: > Thanks Justine! > > On Fri, Nov 17, 2023 at 1

Re: [VOTE] KIP-979 Allow independently stop KRaft processes

2023-11-17 Thread Hailey Ni
Thanks Justine! On Fri, Nov 17, 2023 at 10:40 AM Justine Olshan wrote: > Thanks Hailey for the update. +1 (binding) from me :) > > Justine > > On Thu, Nov 16, 2023 at 11:32 AM Hailey Ni > wrote: > > > Hey Justine, > > > > Thank you very much for the review. > > I've updated the KIP to add a log

Re: [VOTE] KIP-979 Allow independently stop KRaft processes

2023-11-17 Thread Justine Olshan
Thanks Hailey for the update. +1 (binding) from me :) Justine On Thu, Nov 16, 2023 at 11:32 AM Hailey Ni wrote: > Hey Justine, > > Thank you very much for the review. > I've updated the KIP to add a log line stating that when both flags are > given, node-id will take precedence. > > Thanks, > H

Re: [VOTE] KIP-979 Allow independently stop KRaft processes

2023-11-16 Thread Hailey Ni
Hey Justine, Thank you very much for the review. I've updated the KIP to add a log line stating that when both flags are given, node-id will take precedence. Thanks, Hailey On Wed, Nov 15, 2023 at 3:37 PM Justine Olshan wrote: > Hey Hailey, > > Thanks for the KIP. > I wonder if it would be bet

Re: [VOTE] KIP-979 Allow independently stop KRaft processes

2023-11-15 Thread Justine Olshan
Hey Hailey, Thanks for the KIP. I wonder if it would be better to either not allow both flags or if we choose to have node take precedence, at least have a log line stating such. Otherwise the KIP makes sense to me. Justine On Tue, Nov 14, 2023 at 10:17 AM Colin McCabe wrote: > Thanks, Hailey

Re: [VOTE] KIP-979 Allow independently stop KRaft processes

2023-11-14 Thread Colin McCabe
Thanks, Hailey. +1 (binding) Colin On Mon, Nov 13, 2023, at 15:13, Hailey Ni wrote: > Hi Colin, > > Thank you for your review. I removed the "absolute path need to be > provided" line from the KIP, and will modify the code to get the absolute > path to the config files using some bash in the kaf

Re: [VOTE] KIP-979 Allow independently stop KRaft processes

2023-11-13 Thread Hailey Ni
Hi Colin, Thank you for your review. I removed the "absolute path need to be provided" line from the KIP, and will modify the code to get the absolute path to the config files using some bash in the kafka-server-start file. For your second question, I've added a line in the KIP: "If both parameter

Re: [VOTE] KIP-979 Allow independently stop KRaft processes

2023-11-09 Thread Colin McCabe
Hi Hailey, Thanks for the KIP. It feels clunky to have to pass an absolute path to the configuration file when starting the broker or controller. I think we should consider one of two alternate options: 1. Use JMXtool to examine the running kafka.Kafka processes. I believe ID is available from

Re: [VOTE] KIP-979 Allow independently stop KRaft processes

2023-10-23 Thread Hailey Ni
Hi Ron, I've added the "Rejected Alternatives" section in the KIP. Thanks for the comments and +1 vote! Thanks, Hailey On Mon, Oct 23, 2023 at 6:33 AM Ron Dagostino wrote: > Hi Hailey. I'm +1 (binding), but could you add a "Rejected > Alternatives" section to the KIP and mention the "--requir

Re: [VOTE] KIP-979 Allow independently stop KRaft processes

2023-10-23 Thread Ron Dagostino
Hi Hailey. I'm +1 (binding), but could you add a "Rejected Alternatives" section to the KIP and mention the "--required-config " option that we decided against and the reason why we made the decision to reject it? There were some other small things (dash instead of dot in the parameter names, --n

Re: [VOTE] KIP-979 Allow independently stop KRaft processes

2023-10-23 Thread Federico Valeri
+1 (non binding) Thanks. On Mon, Oct 23, 2023 at 9:48 AM Kamal Chandraprakash wrote: > > +1 (non-binding). Thanks for the KIP! > > On Mon, Oct 23, 2023, 12:55 Hailey Ni wrote: > > > Hi all, > > > > I'd like to call a vote on KIP-979 that will allow users to independently > > stop KRaft processe

Re: [VOTE] KIP-979 Allow independently stop KRaft processes

2023-10-23 Thread Kamal Chandraprakash
+1 (non-binding). Thanks for the KIP! On Mon, Oct 23, 2023, 12:55 Hailey Ni wrote: > Hi all, > > I'd like to call a vote on KIP-979 that will allow users to independently > stop KRaft processes. > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-979%3A+Allow+independently+stop+KRaft+pro