Re: [VOTE] KIP-307: Allow to define custom processor names with KStreams DSL

2019-02-27 Thread Bill Bejeck
Florian, So we have re-vote and KIP-307 is excepted with the changes. I've looked in GitHub and I don't see the 5 separate PRs you mentioned on this thread. Can you push those PRs and ping us when they are ready for review? Also, this is an important KIP we'd like to get in sooner rather tha

Re: [VOTE] KIP-307: Allow to define custom processor names with KStreams DSL

2019-02-27 Thread Bill Bejeck
+1(binding) -Bill On 2019/02/27 02:01:41, "Matthias J. Sax" wrote: > +1 (binding) > > > -Matthias > > On 1/25/19 9:49 AM, Guozhang Wang wrote: > > Fair enough; could you summarize the open questions on the DISCUSS thread > > then? > > > > On Fri, Jan 25, 2019 at 9:46 AM Matthias J. Sax > >

Re: [VOTE] KIP-307: Allow to define custom processor names with KStreams DSL

2019-02-26 Thread Guozhang Wang
I think all the open questions have been addressed and updated in the DISCUSS thread, and thus I'm +1 on this KIP now. Guozhang On Tue, Feb 26, 2019 at 6:01 PM Matthias J. Sax wrote: > +1 (binding) > > > -Matthias > > On 1/25/19 9:49 AM, Guozhang Wang wrote: > > Fair enough; could you summariz

Re: [VOTE] KIP-307: Allow to define custom processor names with KStreams DSL

2019-02-26 Thread Matthias J. Sax
+1 (binding) -Matthias On 1/25/19 9:49 AM, Guozhang Wang wrote: > Fair enough; could you summarize the open questions on the DISCUSS thread > then? > > On Fri, Jan 25, 2019 at 9:46 AM Matthias J. Sax > wrote: > >> Guozhang, >> >> KIP deadline passed yesterday. The last comments on the DISCUSS

Re: [VOTE] KIP-307: Allow to define custom processor names with KStreams DSL

2019-01-25 Thread Guozhang Wang
Fair enough; could you summarize the open questions on the DISCUSS thread then? On Fri, Jan 25, 2019 at 9:46 AM Matthias J. Sax wrote: > Guozhang, > > KIP deadline passed yesterday. The last comments on the DISCUSS thread > are not addressed yet. We need to move this to 2.3. > > -Matthias > > On

Re: [VOTE] KIP-307: Allow to define custom processor names with KStreams DSL

2019-01-25 Thread Matthias J. Sax
Guozhang, KIP deadline passed yesterday. The last comments on the DISCUSS thread are not addressed yet. We need to move this to 2.3. -Matthias On 1/24/19 4:23 PM, Guozhang Wang wrote: > Hello folks, > > I'd like to call out for another time on voting for this KIP, given the > deadline is approa

Re: [VOTE] KIP-307: Allow to define custom processor names with KStreams DSL

2019-01-24 Thread Guozhang Wang
Hello folks, I'd like to call out for another time on voting for this KIP, given the deadline is approaching now. Guozhang On Thu, Jan 17, 2019 at 3:11 PM John Roesler wrote: > FWIW, I'm also +1 on the consistency changes to Joined. > > -John > > On Thu, Jan 17, 2019 at 5:04 PM Guozhang Wang

Re: [VOTE] KIP-307: Allow to define custom processor names with KStreams DSL

2019-01-17 Thread John Roesler
FWIW, I'm also +1 on the consistency changes to Joined. -John On Thu, Jan 17, 2019 at 5:04 PM Guozhang Wang wrote: > Hello Florian, > > Thanks for the writeup! I made a pass on the wiki page itself and left a > comment on it regarding the newly added APIs. Could you take a look? If > that makes

Re: [VOTE] KIP-307: Allow to define custom processor names with KStreams DSL

2019-01-17 Thread Guozhang Wang
Hello Florian, Thanks for the writeup! I made a pass on the wiki page itself and left a comment on it regarding the newly added APIs. Could you take a look? If that makes sense could you update the wiki page to make sure we have all the relevant public API changes. Guozhang On Thu, Jan 17, 2019

Re: [VOTE] KIP-307: Allow to define custom processor names with KStreams DSL

2019-01-17 Thread John Roesler
Yes, thanks Florian! +1 (nonbinding) from me. -John On Thu, Jan 17, 2019 at 3:36 PM Bill Bejeck wrote: > Thanks for the KIP Florian, it will be a useful addition. > > +1 on the KIP for me. > > -Bill > > On Thu, Jan 17, 2019 at 4:31 PM Florian Hussonnois > wrote: > > > Hi folks, > > > > I woul

Re: [VOTE] KIP-307: Allow to define custom processor names with KStreams DSL

2019-01-17 Thread Bill Bejeck
Thanks for the KIP Florian, it will be a useful addition. +1 on the KIP for me. -Bill On Thu, Jan 17, 2019 at 4:31 PM Florian Hussonnois wrote: > Hi folks, > > I would like to initiate a vote for the following KIP : > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-307%3A+Allow+to+defi