Florian, So we have re-vote and KIP-307 is excepted with the changes. I've looked in GitHub and I don't see the 5 separate PRs you mentioned on this thread. Can you push those PRs and ping us when they are ready for review?
Also, this is an important KIP we'd like to get in sooner rather than later, so if you find the work is too much of a burden, we can finish up the last bits to get this KIP merged, just let us know. Thanks again for all the work you've put into this. -Bill On 2019/02/27 02:18:20, Guozhang Wang <wangg...@gmail.com> wrote: > I think all the open questions have been addressed and updated in the > DISCUSS thread, and thus I'm +1 on this KIP now. > > > Guozhang > > On Tue, Feb 26, 2019 at 6:01 PM Matthias J. Sax <matth...@confluent.io> > wrote: > > > +1 (binding) > > > > > > -Matthias > > > > On 1/25/19 9:49 AM, Guozhang Wang wrote: > > > Fair enough; could you summarize the open questions on the DISCUSS thread > > > then? > > > > > > On Fri, Jan 25, 2019 at 9:46 AM Matthias J. Sax <matth...@confluent.io> > > > wrote: > > > > > >> Guozhang, > > >> > > >> KIP deadline passed yesterday. The last comments on the DISCUSS thread > > >> are not addressed yet. We need to move this to 2.3. > > >> > > >> -Matthias > > >> > > >> On 1/24/19 4:23 PM, Guozhang Wang wrote: > > >>> Hello folks, > > >>> > > >>> I'd like to call out for another time on voting for this KIP, given the > > >>> deadline is approaching now. > > >>> > > >>> > > >>> Guozhang > > >>> > > >>> On Thu, Jan 17, 2019 at 3:11 PM John Roesler <j...@confluent.io> > > wrote: > > >>> > > >>>> FWIW, I'm also +1 on the consistency changes to Joined. > > >>>> > > >>>> -John > > >>>> > > >>>> On Thu, Jan 17, 2019 at 5:04 PM Guozhang Wang <wangg...@gmail.com> > > >> wrote: > > >>>> > > >>>>> Hello Florian, > > >>>>> > > >>>>> Thanks for the writeup! I made a pass on the wiki page itself and > > left > > >> a > > >>>>> comment on it regarding the newly added APIs. Could you take a look? > > If > > >>>>> that makes sense could you update the wiki page to make sure we have > > >> all > > >>>>> the relevant public API changes. > > >>>>> > > >>>>> > > >>>>> Guozhang > > >>>>> > > >>>>> On Thu, Jan 17, 2019 at 1:39 PM John Roesler <j...@confluent.io> > > >> wrote: > > >>>>> > > >>>>>> Yes, thanks Florian! > > >>>>>> > > >>>>>> +1 (nonbinding) from me. > > >>>>>> > > >>>>>> -John > > >>>>>> > > >>>>>> On Thu, Jan 17, 2019 at 3:36 PM Bill Bejeck <bbej...@gmail.com> > > >> wrote: > > >>>>>> > > >>>>>>> Thanks for the KIP Florian, it will be a useful addition. > > >>>>>>> > > >>>>>>> +1 on the KIP for me. > > >>>>>>> > > >>>>>>> -Bill > > >>>>>>> > > >>>>>>> On Thu, Jan 17, 2019 at 4:31 PM Florian Hussonnois < > > >>>>>> fhussonn...@gmail.com> > > >>>>>>> wrote: > > >>>>>>> > > >>>>>>>> Hi folks, > > >>>>>>>> > > >>>>>>>> I would like to initiate a vote for the following KIP : > > >>>>>>>> > > >>>>>>>> > > >>>>>>> > > >>>>>> > > >>>>> > > >>>> > > >> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-307%3A+Allow+to+define+custom+processor+names+with+KStreams+DSL > > >>>>>>>> > > >>>>>>>> Note, there is still some minor discussions regarding the > > >>>>>> implementation. > > >>>>>>>> > > >>>>>>>> Thanks > > >>>>>>>> -- > > >>>>>>>> Florian HUSSONNOIS > > >>>>>>>> > > >>>>>>> > > >>>>>> > > >>>>> > > >>>>> > > >>>>> -- > > >>>>> -- Guozhang > > >>>>> > > >>>> > > >>> > > >>> > > >> > > >> > > > > > > > > > -- > -- Guozhang >
