Re: [VOTE] KIP-233: Simplify StreamsBuilder#addGlobalStore

2018-01-15 Thread Panuwat Anawatmongkhon
Thank you, Guozhang. The voting thread is finished with three binding votes. I will update KIP status and proceed with the code change and some KIP update. Cheers On Sat, 13 Jan 2561 at 02:39 Guozhang Wang wrote: > Panuwat, > > You have already got three binding votes, could you please close th

Re: [VOTE] KIP-233: Simplify StreamsBuilder#addGlobalStore

2018-01-12 Thread Guozhang Wang
Panuwat, You have already got three binding votes, could you please close this voting thread and proceed? Guozhang On Tue, Jan 9, 2018 at 7:06 AM, Damian Guy wrote: > +1 > > On Wed, 3 Jan 2018 at 03:49 Matthias J. Sax wrote: > > > It must be two different names, as we add two processor to th

Re: [VOTE] KIP-233: Simplify StreamsBuilder#addGlobalStore

2018-01-09 Thread Damian Guy
+1 On Wed, 3 Jan 2018 at 03:49 Matthias J. Sax wrote: > It must be two different names, as we add two processor to the topology: > a source processor that only read the data from a topic, and the actual > processor that maintains the global table. > > > -Matthias > > On 1/2/18 7:14 PM, Ewen Ches

Re: [VOTE] KIP-233: Simplify StreamsBuilder#addGlobalStore

2018-01-02 Thread Matthias J. Sax
It must be two different names, as we add two processor to the topology: a source processor that only read the data from a topic, and the actual processor that maintains the global table. -Matthias On 1/2/18 7:14 PM, Ewen Cheslack-Postava wrote: > +1 binding, seems like a nice simplification. >

Re: [VOTE] KIP-233: Simplify StreamsBuilder#addGlobalStore

2018-01-02 Thread Ewen Cheslack-Postava
+1 binding, seems like a nice simplification. Regarding the source and processor name, do they actually need to be unique or could they use the same value? Since these use incrementing integers, it could be nice for debuggability/understanding to have them use the same name if possible instead of

Re: [VOTE] KIP-233: Simplify StreamsBuilder#addGlobalStore

2018-01-02 Thread Guozhang Wang
On a side note, could you update the "compatibility and upgrade" section, that when users start to make code changes to leverage the new API, what kind of upgrade executions they'd need to do? I feel they need to rename topics / etc. On Tue, Jan 2, 2018 at 9:10 AM, Guozhang Wang wrote: > +1, tha

Re: [VOTE] KIP-233: Simplify StreamsBuilder#addGlobalStore

2018-01-02 Thread Guozhang Wang
+1, thanks! On Wed, Dec 27, 2017 at 6:01 PM, Ted Yu wrote: > +1 > > On Wed, Dec 27, 2017 at 12:15 PM, Bill Bejeck wrote: > > > +1 > > > > On Wed, Dec 27, 2017 at 3:07 PM, Matthias J. Sax > > wrote: > > > > > +1 > > > > > > On 12/26/17 9:00 PM, Panuwat Anawatmongkhon wrote: > > > > Hi all, > >

Re: [VOTE] KIP-233: Simplify StreamsBuilder#addGlobalStore

2017-12-27 Thread Ted Yu
+1 On Wed, Dec 27, 2017 at 12:15 PM, Bill Bejeck wrote: > +1 > > On Wed, Dec 27, 2017 at 3:07 PM, Matthias J. Sax > wrote: > > > +1 > > > > On 12/26/17 9:00 PM, Panuwat Anawatmongkhon wrote: > > > Hi all, > > > I would like to start the vote thread. > > > This is link for the kip. > > > > > > h

Re: [VOTE] KIP-233: Simplify StreamsBuilder#addGlobalStore

2017-12-27 Thread Bill Bejeck
+1 On Wed, Dec 27, 2017 at 3:07 PM, Matthias J. Sax wrote: > +1 > > On 12/26/17 9:00 PM, Panuwat Anawatmongkhon wrote: > > Hi all, > > I would like to start the vote thread. > > This is link for the kip. > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-233%3A+Simplify+ > StreamsBuil

Re: [VOTE] KIP-233: Simplify StreamsBuilder#addGlobalStore

2017-12-27 Thread Matthias J. Sax
+1 On 12/26/17 9:00 PM, Panuwat Anawatmongkhon wrote: > Hi all, > I would like to start the vote thread. > This is link for the kip. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-233%3A+Simplify+StreamsBuilder%23addGlobalStore > > Cheers > signature.asc Description: OpenPGP digit