Re: [VOTE] KIP-195: AdminClient.createPartitions()

2017-09-13 Thread Tom Bentley
The vote has passed. with three binding +1s (Jun, Ismael and Jason), no -1s or +0s. Thanks to those who commented and voted. On 13 September 2017 at 23:22, Jason Gustafson wrote: > +1. Thanks for the KIP. Just one minor clarification: when no assignment is > specified by the user, what will be

Re: [VOTE] KIP-195: AdminClient.createPartitions()

2017-09-13 Thread Jason Gustafson
+1. Thanks for the KIP. Just one minor clarification: when no assignment is specified by the user, what will be sent in the protocol? A null assignment array? Probably worth mentioning this case explicitly in the KIP. Thanks, Jason On Wed, Sep 13, 2017 at 7:53 AM, Tom Bentley wrote: > This KIP

Re: [VOTE] KIP-195: AdminClient.createPartitions()

2017-09-13 Thread Tom Bentley
This KIP currently has 2 binding +1 votes. Today is the deadline for KIPs to be added to Kafka 1.0.0. So if anyone else would like to see this feature in 1.0.0 they will need to vote by the end of the day. If there are insufficient votes for the KIP to be adopted today then I will keep the vote op

Re: [VOTE] KIP-195: AdminClient.createPartitions()

2017-09-13 Thread Ismael Juma
Tom, Thanks for the KIP, +1 (binding) from me. Ismael On Fri, Sep 8, 2017 at 5:42 PM, Tom Bentley wrote: > I would like to start the vote on KIP-195 which adds an AdminClient API for > increasing the number of partitions of a topic. The details are here: > > https://cwiki.apache.org/confluence

Re: [VOTE] KIP-195: AdminClient.createPartitions()

2017-09-12 Thread Jun Rao
Hi, Tom, 2. Thanks for the explanation. That makes sense and we can leave this as it is. Jun On Tue, Sep 12, 2017 at 10:46 AM, Tom Bentley wrote: > Hi Jun, > > Thanks for the comments. > > On 12 September 2017 at 18:15, Jun Rao wrote: > > > Hi, Tom, > > > > Thanks for the KIP. +1. Just a cou

Re: [VOTE] KIP-195: AdminClient.createPartitions()

2017-09-12 Thread Tom Bentley
Hi Jun, Thanks for the comments. On 12 September 2017 at 18:15, Jun Rao wrote: > Hi, Tom, > > Thanks for the KIP. +1. Just a couple of minor comments below. > > 1. The KIP has "INVALID_PARTITIONS (37) If the partition count was <= the > current partition count for the topic." We probably want

Re: [VOTE] KIP-195: AdminClient.createPartitions()

2017-09-12 Thread Jun Rao
Hi, Tom, Thanks for the KIP. +1. Just a couple of minor comments below. 1. The KIP has "INVALID_PARTITIONS (37) If the partition count was <= the current partition count for the topic." We probably want to add one more constraint: # of replicas in each new partition has to be the same as the exi

Re: [VOTE] KIP-195: AdminClient.createPartitions()

2017-09-12 Thread Tom Bentley
Following additional comments from Ismael I have updated the KIP slightly to: * No longer apply the CreateTopicPolicy (a future KIP will address applying a policy to topic changes) * Clarify that the request must be sent to the controller and the response will only be sent once the changes are ref