Hi, Tom, Thanks for the KIP. +1. Just a couple of minor comments below.
1. The KIP has "INVALID_PARTITIONS (37) If the partition count was <= the current partition count for the topic." We probably want to add one more constraint: # of replicas in each new partition has to be the same as the existing replication factor for the topic. 2. The KIP has the following. - REASSIGNMENT_IN_PROGRESS (new) If a partition reassignment is in progress. It is necessary to prevent increasing partitions at the same time so that we can be sure the partition has a meaningful replication factor. Currently, it's possible to increase the partition count while a partition reassignment is in progress (adding partitions is much cheaper than partition reassignment). On the other hand, if a topic is being deleted, we will prevent adding new partitions. So, we probably want to do the same in the KIP. Jun On Tue, Sep 12, 2017 at 9:35 AM, Tom Bentley <t.j.bent...@gmail.com> wrote: > Following additional comments from Ismael I have updated the KIP slightly > to: > > * No longer apply the CreateTopicPolicy (a future KIP will address applying > a policy to topic changes) > * Clarify that the request must be sent to the controller and the response > will only be sent once the changes are reflected in the metadata cache. > > Cheers, > > Tom > > On 8 September 2017 at 17:42, Tom Bentley <t.j.bent...@gmail.com> wrote: > > > I would like to start the vote on KIP-195 which adds an AdminClient API > > for increasing the number of partitions of a topic. The details are here: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-195%3A+AdminClient > . > > createPartitions > > > > Cheers, > > > > Tom > > >
