Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread Sophie Blee-Goldman
ull support for alpha/v1 altogether > > then why not remove all that too? > > > > From: Sophie Blee-Goldman > > Sent: Wednesday, April 14, 2021 5:22 PM > > To: dev > > Subject: Re: [DISCUSS] KIP-732: Deprecate eos-alpha and repl

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread Ismael Juma
: Wednesday, April 14, 2021 5:22 PM > To: dev > Subject: Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta > with eos-v2 > > Well, the method being deprecated has a consumerGroupId parameter... if > it's a "producer only" > application then do the

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread Gary Russell
all that too? From: Sophie Blee-Goldman Sent: Wednesday, April 14, 2021 5:22 PM To: dev Subject: Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2 Well, the method being deprecated has a consumerGroupId parameter... if it's a "producer on

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread Matthias J. Sax
id sendOffsetsToTransaction(Map> OffsetAndMetadata> >>> offsets, String consumerGroupId) ; >>> >>> >>> On Wed, Apr 14, 2021 at 1:54 PM Gary Russell >> wrote: >>> >>>> Sophie, >>>> >>>> Why not also deprecate Producer.sen

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread Sophie Blee-Goldman
roducer.sendOffsetsToTransaction​ method variant > >> with the consumerGroupId​ parameter? > >> > >> This would encourage non-Streams EOS users to move to beta/v2 > >> implementations, and the fallback to alpha/v1 mode code can also be > removed > >> in 4.0. >

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread Matthias J. Sax
______________ >> From: Sophie Blee-Goldman >> Sent: Wednesday, April 14, 2021 4:38 PM >> To: dev >> Subject: Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta >> with eos-v2 >> >> Thanks all. I've updated the KIP to clarify these wil

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread Sophie Blee-Goldman
PM > To: dev > Subject: Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta > with eos-v2 > > Thanks all. I've updated the KIP to clarify these will be removed in 4.0, > and added a note about > logging a warning as well. I agree that some users may se

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread Gary Russell
. From: Sophie Blee-Goldman Sent: Wednesday, April 14, 2021 4:38 PM To: dev Subject: Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2 Thanks all. I've updated the KIP to clarify these will be removed in 4.0, and added a note about logging a warning as well. I

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread Sophie Blee-Goldman
Thanks all. I've updated the KIP to clarify these will be removed in 4.0, and added a note about logging a warning as well. I agree that some users may set the config value directly and could miss the deprecation notice. I'll call for a vote today since there seems to be consensus, but please let

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread Ismael Juma
Hey John, Yes, we should definitely do that. It's meant to be the standard procedure for configs that are deprecated. Ismael On Wed, Apr 14, 2021 at 12:02 PM John Roesler wrote: > Hello again, Sophie, > > I've just had a late-breaking thought about your KIP. It > might be worthwhile also print

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread Bill Bejeck
Hi Sophie, Thanks for the KIP, it makes sense to me. I'm a +1 on the proposal. I'm also a +1 to Ismael's suggestion for stating the removal of the deprecated configs in 4.0 -Bill On Wed, Apr 14, 2021 at 3:02 PM John Roesler wrote: > Hello again, Sophie, > > I've just had a late-breaking thoug

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread John Roesler
Hello again, Sophie, I've just had a late-breaking thought about your KIP. It might be worthwhile also printing a WARN log when the deprecated configs are used. People may not always be referencing the StreamsConfig fields in their source code when they set these configs, so it would be good to ma

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread Guozhang Wang
Thanks Sophie for writing the KIP! I'm +1 on the proposal. On Wed, Apr 14, 2021 at 8:56 AM Ismael Juma wrote: > Thanks Sophie. This makes sense to me. One question: do we want to be a bit > clearer about the removal plans? That is, can we say that the deprecated > configs will be removed in 4.0

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread Ismael Juma
Thanks Sophie. This makes sense to me. One question: do we want to be a bit clearer about the removal plans? That is, can we say that the deprecated configs will be removed in 4.0 (instead of likely to be removed)? The implication would be that exactly-once would only work with 2.5+ while at least

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-14 Thread John Roesler
Thanks for the KIP, Sophie. I think this is a great approach, and it makes perfect sense in the 3.0 release as well. -John On Wed, Apr 14, 2021, at 01:17, Bruno Cadonna wrote: > Hi Sophie, > > the KIP makes sense to me! Thank you for writing it! > > Best, > Bruno > > On 14.04.21 04:52, Soph

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-13 Thread Bruno Cadonna
Hi Sophie, the KIP makes sense to me! Thank you for writing it! Best, Bruno On 14.04.21 04:52, Sophie Blee-Goldman wrote: Hey all, I'd like to kick off discussion on a small KIP to move towards a unified EOS and clean up the current options. Please give it a pass and let me know what you thin

Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-13 Thread Atul Anand
i will burn you to the ground!!! On Wed, 14 Apr 2021 at 08:23, Sophie Blee-Goldman wrote: > Hey all, > > I'd like to kick off discussion on a small KIP to move towards a unified > EOS and clean up the current options. Please give it a pass and let me know > what you think. > > KIP-7