Hello again, Sophie, I've just had a late-breaking thought about your KIP. It might be worthwhile also printing a WARN log when the deprecated configs are used. People may not always be referencing the StreamsConfig fields in their source code when they set these configs, so it would be good to make an extra effort to raise the visibility of this deprecation.
Thanks, -John On Wed, 2021-04-14 at 10:47 -0700, Guozhang Wang wrote: > Thanks Sophie for writing the KIP! I'm +1 on the proposal. > > On Wed, Apr 14, 2021 at 8:56 AM Ismael Juma <ism...@juma.me.uk> wrote: > > > Thanks Sophie. This makes sense to me. One question: do we want to be a bit > > clearer about the removal plans? That is, can we say that the deprecated > > configs will be removed in 4.0 (instead of likely to be removed)? The > > implication would be that exactly-once would only work with 2.5+ while at > > least once would work with all versions. 4.0 is probably 1.5-2 years away, > > so this seems reasonable to me. > > > > Ismael > > > > On Tue, Apr 13, 2021 at 7:53 PM Sophie Blee-Goldman > > <sop...@confluent.io.invalid> wrote: > > > > > Hey all, > > > > > > I'd like to kick off discussion on a small KIP to move towards a unified > > > EOS and clean up the current options. Please give it a pass and let me > > know > > > what you think. > > > > > > KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2 > > > < > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-732%3A+Deprecate+eos-alpha+and+replace+eos-beta+with+eos-v2 > > > > > > > KAFKA-12574: Deprecate eos-alpha > > > <https://issues.apache.org/jira/browse/KAFKA-12574> > > > > > > Thanks, > > > Sophie > > > > > > >
