[jira] [Commented] (KAFKA-871) Rename ZkConfig properties

2013-04-25 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642347#comment-13642347 ] Swapnil Ghike commented on KAFKA-871: - Attached patch v4. I think v4 fixes the system

[jira] [Commented] (KAFKA-871) Rename ZkConfig properties

2013-04-25 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641966#comment-13641966 ] John Fung commented on KAFKA-871: - [~swapnilghike] : The test result is showing 0 messages

[jira] [Commented] (KAFKA-871) Rename ZkConfig properties

2013-04-25 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641942#comment-13641942 ] Jun Rao commented on KAFKA-871: --- Thanks for patch v3. Looks good. The following config is wei

[jira] [Commented] (KAFKA-871) Rename ZkConfig properties

2013-04-24 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641323#comment-13641323 ] Swapnil Ghike commented on KAFKA-871: - 1. Removed the aforementioned noise from patch v

[jira] [Commented] (KAFKA-871) Rename ZkConfig properties

2013-04-24 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640711#comment-13640711 ] John Fung commented on KAFKA-871: - The following are older system testing scripts in bash b

[jira] [Commented] (KAFKA-871) Rename ZkConfig properties

2013-04-24 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640667#comment-13640667 ] Swapnil Ghike commented on KAFKA-871: - I will exclude them from v3 to reduce the noise

[jira] [Commented] (KAFKA-871) Rename ZkConfig properties

2013-04-24 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640665#comment-13640665 ] Swapnil Ghike commented on KAFKA-871: - According to [~jfung], anything under system_tes

[jira] [Commented] (KAFKA-871) Rename ZkConfig properties

2013-04-24 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640553#comment-13640553 ] Jun Rao commented on KAFKA-871: --- Some comments on patch v2. There are a few places that we ch

[jira] [Commented] (KAFKA-871) Rename ZkConfig properties

2013-04-23 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640151#comment-13640151 ] Swapnil Ghike commented on KAFKA-871: - We should hold off checking this patch in until

[jira] [Commented] (KAFKA-871) Rename ZkConfig properties

2013-04-23 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639382#comment-13639382 ] John Fung commented on KAFKA-871: - Hi Swapnil, In system_test/migration_tool_testsuite, th

[jira] [Commented] (KAFKA-871) Rename ZkConfig properties

2013-04-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639364#comment-13639364 ] Jun Rao commented on KAFKA-871: --- metadata.broker.list is fine. > Rename ZkCo

[jira] [Commented] (KAFKA-871) Rename ZkConfig properties

2013-04-23 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639359#comment-13639359 ] Swapnil Ghike commented on KAFKA-871: - How about using metadata.broker.list or metadata

[jira] [Commented] (KAFKA-871) Rename ZkConfig properties

2013-04-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639244#comment-13639244 ] Jun Rao commented on KAFKA-871: --- Thanks for the patch. For clarity, should we rename broker.l

[jira] [Commented] (KAFKA-871) Rename ZkConfig properties

2013-04-22 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638696#comment-13638696 ] Swapnil Ghike commented on KAFKA-871: - [~jfung]: Could you take a look at this patch? S