[ 
https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641323#comment-13641323
 ] 

Swapnil Ghike commented on KAFKA-871:
-------------------------------------

1. Removed the aforementioned noise from patch v3.
2. The additional interesting change is a one character fix to JSON parsing in 
seqToJson in Utils.scala. We were not building the comma separated string 
correctly earlier, and this bug was not exposed because that particular 
condition was not exercised.
3. Added zookeeper.connect and zookeeper.connection.timeout.ms to 
migration_tool_testsuite/config/server.properties, because we are currently 
using only 1 server.properties file for both kafka 0.7 and 0.8 brokers. 
KAFKA-874 will create two separate config files for 0.7 and 0.8 brokers.

Testing:
1. Unit tests pass.
2. As [~jfung] suggested, tested migration tool test case 9001. It passed:

_test_case_name  :  testcase_9001
_test_class_name  :  MigrationToolTest
arg : bounce_migration_tool  :  false
arg : message_producing_free_time_sec  :  30
arg : num_iteration  :  1
arg : num_messages_to_produce_per_producer_call  :  50
arg : num_partition  :  1
arg : replica_factor  :  3
arg : sleep_seconds_between_producer_calls  :  1
validation_status  : 
     Unique messages from consumer on [test_1]  :  0
     Unique messages from producer on [test_1]  :  0

Total failures count : 0


                
> Rename ZkConfig properties
> --------------------------
>
>                 Key: KAFKA-871
>                 URL: https://issues.apache.org/jira/browse/KAFKA-871
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Swapnil Ghike
>            Assignee: Swapnil Ghike
>            Priority: Blocker
>              Labels: kafka-0.8, p1
>         Attachments: kafka-871-v1.patch, kafka-871-v2.patch, 
> kafka-871-v3.patch
>
>
> For clarity. Renaming these properties should help in migration from 0.7 to 
> 0.8.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to