[ 
https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642347#comment-13642347
 ] 

Swapnil Ghike commented on KAFKA-871:
-------------------------------------

Attached patch v4. 

I think v4 fixes the system test. Ran 3 test cases according to [~jfung]'s 
advice:

_test_case_name  :  testcase_5001
_test_class_name  :  MirrorMakerTest
arg : bounce_leader  :  false
arg : bounce_mirror_maker  :  false
arg : message_producing_free_time_sec  :  15
arg : num_iteration  :  1
arg : num_messages_to_produce_per_producer_call  :  50
arg : num_partition  :  1
arg : replica_factor  :  3
arg : sleep_seconds_between_producer_calls  :  1
validation_status  :-
     Unique messages from consumer on [test_1]  :  500
     Unique messages from producer on [test_1]  :  500
     Validate for data matched on topic [test_1]  :  PASSED
     Validate for merged log segment checksum in cluster [source]  :  PASSED
     Validate for merged log segment checksum in cluster [target]  :  PASSED

_test_case_name  :  testcase_0001
_test_class_name  :  ReplicaBasicTest
arg : bounce_broker  :  false
arg : broker_type  :  leader
arg : message_producing_free_time_sec  :  15
arg : num_iteration  :  1
arg : num_messages_to_produce_per_producer_call  :  50
arg : num_partition  :  1
arg : replica_factor  :  3
arg : sleep_seconds_between_producer_calls  :  1
validation_status  :-
     Leader Election Latency MAX  :  None
     Leader Election Latency MIN  :  None
     No. of messages from consumer on [test_1] at 
simple_consumer_test_1-0_r1.log  :  500
     No. of messages from consumer on [test_1] at 
simple_consumer_test_1-0_r2.log  :  500
     No. of messages from consumer on [test_1] at 
simple_consumer_test_1-0_r3.log  :  500
     Unique messages from consumer on [test_1]  :  500
     Unique messages from producer on [test_1]  :  500
     Validate for data matched on topic [test_1]  :  PASSED
     Validate for data matched on topic [test_1] across replicas  :  PASSED
     Validate for merged log segment checksum in cluster [source]  :  PASSED
     Validate index log in cluster [source]  :  PASSED

_test_case_name : testcase_9001
_test_class_name : MigrationToolTest
validation_status : 
     Unique messages from consumer on [test_1] : 10500
     Unique messages from producer on [test_1] : 10500

Unit tests pass.

                
> Rename ZkConfig properties
> --------------------------
>
>                 Key: KAFKA-871
>                 URL: https://issues.apache.org/jira/browse/KAFKA-871
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Swapnil Ghike
>            Assignee: Swapnil Ghike
>            Priority: Blocker
>              Labels: kafka-0.8, p1
>         Attachments: kafka-871-v1.patch, kafka-871-v2.patch, 
> kafka-871-v3.patch, kafka-871-v4.patch
>
>
> For clarity. Renaming these properties should help in migration from 0.7 to 
> 0.8.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to