[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633766#comment-14633766 ] ASF GitHub Bot commented on KAFKA-2169: --- Github user Parth-Brahmbhatt closed the pul

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-15 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545817#comment-14545817 ] Parth Brahmbhatt commented on KAFKA-2169: - [~junrao] updated the review with chang

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-15 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545814#comment-14545814 ] Parth Brahmbhatt commented on KAFKA-2169: - Updated reviewboard https://reviews.apa

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542708#comment-14542708 ] Jun Rao commented on KAFKA-2169: Thought a bit more about this. When handling handleSessio

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538713#comment-14538713 ] Parth Brahmbhatt commented on KAFKA-2169: - [~junrao] 1) Yes I tested with 0.8.2 an

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538709#comment-14538709 ] Jun Rao commented on KAFKA-2169: Parth, 1. Have you done the api compatibility test? 3. D

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538629#comment-14538629 ] Parth Brahmbhatt commented on KAFKA-2169: - Updated reviewboard https://reviews.apa

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538592#comment-14538592 ] Jun Rao commented on KAFKA-2169: 1) By api compatibility, I meant the following. Let's say

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538409#comment-14538409 ] Parth Brahmbhatt commented on KAFKA-2169: - Posted a review on review board. https:

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538376#comment-14538376 ] Parth Brahmbhatt commented on KAFKA-2169: - Created reviewboard https://reviews.apa

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538313#comment-14538313 ] Parth Brahmbhatt commented on KAFKA-2169: - Created reviewboard https://reviews.apa

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538199#comment-14538199 ] Jun Rao commented on KAFKA-2169: Parth, Thanks for the patch. Since we haven't officially

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-09 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536281#comment-14536281 ] Igor Maravić commented on KAFKA-2169: - [~parth.brahmbhatt] If you look at the stack tr

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-08 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534802#comment-14534802 ] Parth Brahmbhatt commented on KAFKA-2169: - Here is the commit that added that meth

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-08 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534743#comment-14534743 ] Igor Maravić commented on KAFKA-2169: - We, Spotify, have just been hit by a BUG that's

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533309#comment-14533309 ] ASF GitHub Bot commented on KAFKA-2169: --- GitHub user Parth-Brahmbhatt opened a pull

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-04 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526996#comment-14526996 ] Parth Brahmbhatt commented on KAFKA-2169: - I am working on a patch for this as the