Re: [VOTE] KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-06-14 Thread David Jacot
Thanks for the update, Niket. LGTM. On Tue, Jun 14, 2022 at 3:43 AM Niket Goel wrote: > > Thanks for taking a look Gouzhang. > That is an accurate summary of the changes. > > - Niket > > > On Jun 13, 2022, at 2:19 PM, Guozhang Wang wrote: > > > > Hello Niket, > > > > I took a look at the diffs o

Re: [VOTE] KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-06-13 Thread Niket Goel
Thanks for taking a look Gouzhang. That is an accurate summary of the changes. - Niket > On Jun 13, 2022, at 2:19 PM, Guozhang Wang wrote: > > Hello Niket, > > I took a look at the diffs of the wiki page history and it seems the > updates are: > > 1) Removing the topic name from QuorumInfo. >

Re: [VOTE] KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-06-13 Thread Guozhang Wang
Hello Niket, I took a look at the diffs of the wiki page history and it seems the updates are: 1) Removing the topic name from QuorumInfo. 2) Making ReplicaState public APIs more aligned with existing ones. 3) Renaming from DescribeQuorumResult to DescribeMetadataQuorumResult. Is that all? If ye

Re: [VOTE] KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-06-13 Thread Niket Goel
Hi all, An update on KIP-836; while iterating on the PR some finer details in the naming of the API handler and related classes in the Admin Client has changed. I have updated the KIP with the changes. Please provide any feedback you may have on the changes made. PR - https://github.com/apache/

Re: [VOTE] KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-05-24 Thread José Armando García Sancio
+1 (binding). On Mon, May 23, 2022 at 11:52 AM Niket Goel wrote: > > Thanks everyone for the feedback on this. KIP-836 was approved with > 3 binding votes from Luke, David Arthur and David Jacot. > - Niket > > > On May 20, 2022, at 11:44 PM, David Jacot wrote: > > > > +1 (binding) > > > > Thanks

Re: [VOTE] KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-05-23 Thread Niket Goel
Thanks everyone for the feedback on this. KIP-836 was approved with 3 binding votes from Luke, David Arthur and David Jacot. - Niket > On May 20, 2022, at 11:44 PM, David Jacot wrote: > > +1 (binding) > > Thanks for the KIP! > > David > > Le ven. 20 mai 2022 à 21:08, David Arthur a écrit : >

Re: [VOTE] KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-05-20 Thread David Jacot
+1 (binding) Thanks for the KIP! David Le ven. 20 mai 2022 à 21:08, David Arthur a écrit : > Hey Niket, +1 (binding) from me. > > -David > > On Thu, May 19, 2022 at 2:07 PM José Armando García Sancio > wrote: > > > Hey Niket, > > > > I took a look at the latest KIP. It looks like QuorumInfo.R

Re: [VOTE] KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-05-20 Thread David Arthur
Hey Niket, +1 (binding) from me. -David On Thu, May 19, 2022 at 2:07 PM José Armando García Sancio wrote: > Hey Niket, > > I took a look at the latest KIP. It looks like QuorumInfo.ReplicaState > is missing the RPC fields added by this PR. Is the plan to return them > to the Admin Client? E.g.

Re: [VOTE] KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-05-19 Thread José Armando García Sancio
Hey Niket, I took a look at the latest KIP. It looks like QuorumInfo.ReplicaState is missing the RPC fields added by this PR. Is the plan to return them to the Admin Client? E.g. it is missing LastFetchTimestamp and LastCaughtUpTimestamp. For those fields what will the admin client return when th

Re: [VOTE] KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-05-18 Thread Luke Chen
Hi Niket, Thanks for the KIP! +1 (binding) from me. Luke On Thu, May 19, 2022 at 8:27 AM deng ziming wrote: > +1(non-binding) > > Thanks for this KIP. > -- > Best, > Ziming > > > On May 17, 2022, at 1:14 AM, Niket Goel > wrote: > > > > Hi all, > > > > I would like to start a vote for KIP-836:

Re: [VOTE] KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-05-18 Thread deng ziming
+1(non-binding) Thanks for this KIP. -- Best, Ziming > On May 17, 2022, at 1:14 AM, Niket Goel wrote: > > Hi all, > > I would like to start a vote for KIP-836: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-836%3A+Addition+of+Information+in+DescribeQuorumResponse+about+Voter+Lag > >

Re: [VOTE] KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-05-17 Thread Jason Gustafson
+1 Thanks for the KIP! On Mon, May 16, 2022 at 10:14 AM Niket Goel wrote: > Hi all, > > I would like to start a vote for KIP-836: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-836%3A+Addition+of+Information+in+DescribeQuorumResponse+about+Voter+Lag > > Thanks > Niket Goel >

[VOTE] KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-05-16 Thread Niket Goel
Hi all, I would like to start a vote for KIP-836: https://cwiki.apache.org/confluence/display/KAFKA/KIP-836%3A+Addition+of+Information+in+DescribeQuorumResponse+about+Voter+Lag Thanks Niket Goel