Hello Niket, I took a look at the diffs of the wiki page history and it seems the updates are:
1) Removing the topic name from QuorumInfo. 2) Making ReplicaState public APIs more aligned with existing ones. 3) Renaming from DescribeQuorumResult to DescribeMetadataQuorumResult. Is that all? If yes, I'm +1 on the changes. Guozhang On Mon, Jun 13, 2022 at 2:09 PM Niket Goel <ng...@confluent.io.invalid> wrote: > Hi all, > > An update on KIP-836; while iterating on the PR some finer details in the > naming of the API handler and related classes in the Admin Client has > changed. > I have updated the KIP with the changes. Please provide any feedback you > may have on the changes made. > > PR - https://github.com/apache/kafka/pull/12206 > KIP - > https://cwiki.apache.org/confluence/display/KAFKA/KIP-836%3A+Addition+of+Information+in+DescribeQuorumResponse+about+Voter+Lag > > Thanks > - Niket > > > > On May 24, 2022, at 2:30 PM, José Armando García Sancio > <jsan...@confluent.io.invalid> wrote: > > > > +1 (binding). > > > > On Mon, May 23, 2022 at 11:52 AM Niket Goel <ng...@confluent.io.invalid> > wrote: > >> > >> Thanks everyone for the feedback on this. KIP-836 was approved with > >> 3 binding votes from Luke, David Arthur and David Jacot. > >> - Niket > >> > >>> On May 20, 2022, at 11:44 PM, David Jacot <da...@apache.org> wrote: > >>> > >>> +1 (binding) > >>> > >>> Thanks for the KIP! > >>> > >>> David > >>> > >>> Le ven. 20 mai 2022 à 21:08, David Arthur <mum...@gmail.com> a écrit : > >>> > >>>> Hey Niket, +1 (binding) from me. > >>>> > >>>> -David > >>>> > >>>> On Thu, May 19, 2022 at 2:07 PM José Armando García Sancio > >>>> <jsan...@confluent.io.invalid> wrote: > >>>> > >>>>> Hey Niket, > >>>>> > >>>>> I took a look at the latest KIP. It looks like > QuorumInfo.ReplicaState > >>>>> is missing the RPC fields added by this PR. Is the plan to return > them > >>>>> to the Admin Client? E.g. it is missing LastFetchTimestamp and > >>>>> LastCaughtUpTimestamp. > >>>>> > >>>>> For those fields what will the admin client return when the RPC > >>>>> version doesn't support those features? > >>>>> > >>>>> -- > >>>>> -José > >>>>> > >>>> > >>>> > >>>> -- > >>>> David Arthur > >>>> > >> > > > > > > -- > > -José > > -- -- Guozhang
