Re: [VOTE] KIP-133: List and Alter Configs Admin APIs (second attempt)

2017-05-11 Thread Ismael Juma
Thanks for all who provided feedback and voted. The vote passed with 5 binding +1s (Sriram, Guozhang, Jason, Jun, Ismael) and 3 non-binding +1s (Colin, Robert, James). Ismael On Fri, May 12, 2017 at 1:54 AM, Jun Rao wrote: > Hi, Ismael, > > Thanks for the update KIP. +1 > > Jun > > On Thu, May

Re: [VOTE] KIP-133: List and Alter Configs Admin APIs (second attempt)

2017-05-11 Thread Jun Rao
Hi, Ismael, Thanks for the update KIP. +1 Jun On Thu, May 11, 2017 at 4:13 PM, Ismael Juma wrote: > Thanks for the feedback Jun. > > 1. This is a good point. After thinking about it, I concluded that quotas > should be handled via separate APIs, so I moved it to future work. I quote > the reas

Re: [VOTE] KIP-133: List and Alter Configs Admin APIs (second attempt)

2017-05-11 Thread Ismael Juma
Thanks for the feedback Jun. 1. This is a good point. After thinking about it, I concluded that quotas should be handled via separate APIs, so I moved it to future work. I quote the reasoning from the KIP: "Support for reading and updating client, user and replication quotas. We initially include

Re: [VOTE] KIP-133: List and Alter Configs Admin APIs (second attempt)

2017-05-10 Thread Jason Gustafson
+1 Thanks for the KIP. On Wed, May 10, 2017 at 8:55 AM, Jun Rao wrote: > Hi, Ismael, > > Thanks for the KIP. Looks good overall. A couple of minor comments. > > 1. Currently, quotas can be updated at the combination > level. So, it seems that we need to reflect that somehow in both the wire > p

Re: [VOTE] KIP-133: List and Alter Configs Admin APIs (second attempt)

2017-05-10 Thread Jun Rao
Hi, Ismael, Thanks for the KIP. Looks good overall. A couple of minor comments. 1. Currently, quotas can be updated at the combination level. So, it seems that we need to reflect that somehow in both the wire protocol and the admin api. 2. It would be useful to clarify what configs are considere

Re: [VOTE] KIP-133: List and Alter Configs Admin APIs (second attempt)

2017-05-09 Thread James Cheng
+1 (non-binding) James > On May 8, 2017, at 12:01 AM, Ismael Juma wrote: > > [Seems like the original message ended up in the discuss thread in GMail, > so trying again] > > Hi everyone, > > I believe I addressed the comments in the discussion thread and given the > impending KIP freeze, I wo

Re: [VOTE] KIP-133: List and Alter Configs Admin APIs (second attempt)

2017-05-08 Thread Robert Benson
+1 (non-binding) On Sun, May 7, 2017 at 9:01 PM, Ismael Juma wrote: > [Seems like the original message ended up in the discuss thread in GMail, > so trying again] > > Hi everyone, > > I believe I addressed the comments in the discussion thread and given the > impending KIP freeze, I would like t

Re: [VOTE] KIP-133: List and Alter Configs Admin APIs (second attempt)

2017-05-08 Thread Guozhang Wang
+1 On Mon, May 8, 2017 at 10:48 AM, Colin McCabe wrote: > +1 (non-binding) > > best, > Colin > > > On Mon, May 8, 2017, at 08:52, Ismael Juma wrote: > > Quick update, I renamed ListConfigs to DescribeConfigs (and related > > classes > > and methods) as that is more consistent with other protocol

Re: [VOTE] KIP-133: List and Alter Configs Admin APIs (second attempt)

2017-05-08 Thread Colin McCabe
+1 (non-binding) best, Colin On Mon, May 8, 2017, at 08:52, Ismael Juma wrote: > Quick update, I renamed ListConfigs to DescribeConfigs (and related > classes > and methods) as that is more consistent with other protocols (like > ListGroups and DescribeGroups). So the new link is: > > https://c

Re: [VOTE] KIP-133: List and Alter Configs Admin APIs (second attempt)

2017-05-08 Thread Ismael Juma
Quick update, I renamed ListConfigs to DescribeConfigs (and related classes and methods) as that is more consistent with other protocols (like ListGroups and DescribeGroups). So the new link is: https://cwiki.apache.org/confluence/display/KAFKA/KIP-133%3A+Describe+and+Alter+Configs+Admin+APIs Ism

Re: [VOTE] KIP-133: List and Alter Configs Admin APIs (second attempt)

2017-05-07 Thread Sriram Subramanian
+1 > On May 7, 2017, at 9:01 PM, Ismael Juma wrote: > > [Seems like the original message ended up in the discuss thread in GMail, > so trying again] > > Hi everyone, > > I believe I addressed the comments in the discussion thread and given the > impending KIP freeze, I would like to start the

[VOTE] KIP-133: List and Alter Configs Admin APIs (second attempt)

2017-05-07 Thread Ismael Juma
[Seems like the original message ended up in the discuss thread in GMail, so trying again] Hi everyone, I believe I addressed the comments in the discussion thread and given the impending KIP freeze, I would like to start the voting process for KIP-133: List and Alter Configs Admin APIs: https:/