Thanks for the feedback Jun. 1. This is a good point. After thinking about it, I concluded that quotas should be handled via separate APIs, so I moved it to future work. I quote the reasoning from the KIP:
"Support for reading and updating client, user and replication quotas. We initially included that in the KIP, but it subsequently became apparent that a separate protocol and AdminClient API would be more appropriate. The reason is that client/user quotas can be applied on a client id, user or (client id, user) tuple. In the future, the hierarchy may get even more complicated. So, it makes sense to keeping the API simple for the simple cases while introducing a more sophisticated API for the more complex case." 2. I have clarified it. Ismael On Wed, May 10, 2017 at 4:55 PM, Jun Rao <j...@confluent.io> wrote: > Hi, Ismael, > > Thanks for the KIP. Looks good overall. A couple of minor comments. > > 1. Currently, quotas can be updated at the <user, clientId> combination > level. So, it seems that we need to reflect that somehow in both the wire > protocol and the admin api. > 2. It would be useful to clarify what configs are considered read-only. > > Jun > > On Mon, May 8, 2017 at 8:52 AM, Ismael Juma <ism...@juma.me.uk> wrote: > > > Quick update, I renamed ListConfigs to DescribeConfigs (and related > classes > > and methods) as that is more consistent with other protocols (like > > ListGroups and DescribeGroups). So the new link is: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 133%3A+Describe+and+Alter+Configs+Admin+APIs > > > > Ismael > > > > On Mon, May 8, 2017 at 5:01 AM, Ismael Juma <ism...@juma.me.uk> wrote: > > > > > [Seems like the original message ended up in the discuss thread in > GMail, > > > so trying again] > > > > > > Hi everyone, > > > > > > I believe I addressed the comments in the discussion thread and given > the > > > impending KIP freeze, I would like to start the voting process for > > KIP-133: > > > List and Alter Configs Admin APIs: > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-133%3A > > > +List+and+Alter+Configs+Admin+APIs > > > > > > As mentioned previously, this KIP and KIP-140 (Add administrative RPCs > > for > > > adding, deleting, and listing ACLs) complete the AdminClient work that > > was > > > originally proposed as part KIP-4. > > > > > > If you have additional feedback, please share it in the discuss thread. > > > > > > The vote will run for a minimum of 72 hours. > > > > > > Thanks, > > > Ismael > > > > > >
