+1 Thanks for the KIP. On Wed, May 10, 2017 at 8:55 AM, Jun Rao <j...@confluent.io> wrote:
> Hi, Ismael, > > Thanks for the KIP. Looks good overall. A couple of minor comments. > > 1. Currently, quotas can be updated at the <user, clientId> combination > level. So, it seems that we need to reflect that somehow in both the wire > protocol and the admin api. > 2. It would be useful to clarify what configs are considered read-only. > > Jun > > On Mon, May 8, 2017 at 8:52 AM, Ismael Juma <ism...@juma.me.uk> wrote: > > > Quick update, I renamed ListConfigs to DescribeConfigs (and related > classes > > and methods) as that is more consistent with other protocols (like > > ListGroups and DescribeGroups). So the new link is: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 133%3A+Describe+and+Alter+Configs+Admin+APIs > > > > Ismael > > > > On Mon, May 8, 2017 at 5:01 AM, Ismael Juma <ism...@juma.me.uk> wrote: > > > > > [Seems like the original message ended up in the discuss thread in > GMail, > > > so trying again] > > > > > > Hi everyone, > > > > > > I believe I addressed the comments in the discussion thread and given > the > > > impending KIP freeze, I would like to start the voting process for > > KIP-133: > > > List and Alter Configs Admin APIs: > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-133%3A > > > +List+and+Alter+Configs+Admin+APIs > > > > > > As mentioned previously, this KIP and KIP-140 (Add administrative RPCs > > for > > > adding, deleting, and listing ACLs) complete the AdminClient work that > > was > > > originally proposed as part KIP-4. > > > > > > If you have additional feedback, please share it in the discuss thread. > > > > > > The vote will run for a minimum of 72 hours. > > > > > > Thanks, > > > Ismael > > > > > >
