Re: [VOTE] 3.9.0 RC3

2024-10-25 Thread Colin McCabe
Hi Luke, Thanks for the docs PR. I pushed some changes to add a better description of static vs. dynamic quorums, and how the user can tell which one they're running. Take a look. best, Colin On Fri, Oct 25, 2024, at 05:27, Luke Chen wrote: > Hi Colin, > > I opened a PR

Re: [VOTE] 3.9.0 RC3

2024-10-25 Thread Luke Chen
Hi Colin, I opened a PR to add the limitation section in the "Controller membership changes" chapter. If there are other things needed to be added, please let me know. But since it's only doc change, it won't block the RC voting. Thanks. Luke On Fri,

Re: [VOTE] 3.9.0 RC3

2024-10-25 Thread TengYao Chi
Hi Colin, Thanks for handling the release of the new RC. I built from source and ran all the unit and integration tests on each combination of different LTS JDK versions and distributions in Docker (Zulu and Corretto). +1 (non-binding) Thanks, TengYao Justine Olshan 於 2024年10月24日 週四 下午2:24寫道:

Re: [VOTE] 3.9.0 RC3

2024-10-24 Thread Luke Chen
Hi Colin, Thanks for the explanation. And I agree with Mickael that if there are such limitations, we should clearly document it. So far, in the v3.9 document , I can't see anything about it. Also, it seems metrics are still not added, we should docu

Re: [VOTE] 3.9.0 RC3

2024-10-24 Thread Mickael Maison
Hi Colin, This is a major caveat. We've advertised KRaft as production ready and anyone who has already migrated is now stuck with a static quorum. The whole point of 3.9.0 was to reach "feature parity" with ZooKeeper, this is now true for only a subset of users (users that have not already migrat

Re: [VOTE] 3.9.0 RC3

2024-10-24 Thread Justine Olshan
Thanks Colin. Let me know if you need any help with reviews here. Justine On Thu, Oct 24, 2024 at 10:45 AM Colin McCabe wrote: > Hi Justine, > > I looked at this again, and it seems like we somehow dropped the code to > handle --feature. I filed a blocker JIRA to fix: Do not ignore --feature >

Re: [VOTE] 3.9.0 RC3

2024-10-24 Thread Colin McCabe
Hi Luke, Unfortunately, we don't have a way to upgrade from static quorums to dynamic quorums yet. We are hoping to include this in the next release. We're trakcing it under https://issues.apache.org/jira/browse/KAFKA-16538 . best, Colin On Thu, Oct 24, 2024, at 05:25, Luke Chen wrote: > Hi C

Re: [VOTE] 3.9.0 RC3

2024-10-24 Thread Colin McCabe
Hi Justine, I looked at this again, and it seems like we somehow dropped the code to handle --feature. I filed a blocker JIRA to fix: Do not ignore --feature flag in kafka-storage.sh I will also add some more junit tests in this area. Sadly, I guess that means we'll need an RC4. thanks, Colin

Re: [VOTE] 3.9.0 RC3

2024-10-24 Thread Colin McCabe
On Wed, Oct 23, 2024, at 23:22, Justine Olshan wrote: > Hey Colin, > > Thanks for running the release. > > I checked the keys and scanned the docs > I built from source, used kraft quickstart, ran a transactions workload, > played around with a few other things including running some of the feature

Re: [VOTE] 3.9.0 RC3

2024-10-24 Thread Luke Chen
Hi Colin, I found I cannot upgrade to v3.9.0 and then successfully add a new controller or remove a controller. I've opened KAFKA-17866 . Please take a look. Thanks. Luke On Thu, Oct 24, 2024 at 2:27 PM TengYao Chi wrote: > Hi Colin, > > Thank

Re: [VOTE] 3.9.0 RC3

2024-10-23 Thread Justine Olshan
Hey Colin, Thanks for running the release. I checked the keys and scanned the docs I built from source, used kraft quickstart, ran a transactions workload, played around with a few other things including running some of the feature version commands. I noticed that some of the KIP-1022 work that

Re: [VOTE] 3.9.0 RC3

2024-10-22 Thread Bill Bejeck
Hi Colin, Thanks for running the release. I did the following verification steps: 1. Built from source 2. Validated all checksums 3. Ran all the unit tests 4. Pulled both docker images and started up Kafka 5. Ran the KRaft quick start 6. Ran the ZK quick start 7. Ran the Kaf

Re: [VOTE] 3.9.0 RC3

2024-10-22 Thread Federico Valeri
Hi, I did the following tests: - Ran all unit and integration tests - Spot checked the documentation - Tried out new Maven dependencies - Tested KIP-853, KIP-950, KIP-956 and KIP-1057 +1 (non binding) Thanks Fede On Mon, Oct 21, 2024 at 11:12 PM Colin McCabe wrote: > > This is the third candi

[VOTE] 3.9.0 RC3

2024-10-21 Thread Colin McCabe
This is the third candidate for the release of Apache Kafka 3.9.0. I have titled it rc3 since I had an rc1 which got very far, even to the point of pushing tags and docker images, before I spotted an issue. So rather than mutate the tags, I decided to skip over rc1. - This is a major release, t