Hi Luke, Thanks for the docs PR. I pushed some changes to add a better description of static vs. dynamic quorums, and how the user can tell which one they're running. Take a look.
best, Colin On Fri, Oct 25, 2024, at 05:27, Luke Chen wrote: > Hi Colin, > > I opened a PR <https://github.com/apache/kafka/pull/17598> to add the > limitation section in the "Controller membership changes" chapter. > If there are other things needed to be added, please let me know. > > But since it's only doc change, it won't block the RC voting. > > Thanks. > Luke > > On Fri, Oct 25, 2024 at 2:31 PM Luke Chen <show...@gmail.com> wrote: > >> Hi Colin, >> >> Thanks for the explanation. And I agree with Mickael that if there are >> such limitations, we should clearly document it. >> So far, in the v3.9 document >> <https://kafka.apache.org/39/documentation.html>, I can't see anything >> about it. >> Also, it seems metrics are still not added, we should document it, too. >> >> >> Thanks. >> Luke >> >> >> On Fri, Oct 25, 2024 at 3:20 AM Mickael Maison <mickael.mai...@gmail.com> >> wrote: >> >>> Hi Colin, >>> >>> This is a major caveat. We've advertised KRaft as production ready and >>> anyone who has already migrated is now stuck with a static quorum. The >>> whole point of 3.9.0 was to reach "feature parity" with ZooKeeper, >>> this is now true for only a subset of users (users that have not >>> already migrated, or created new KRaft clusters). >>> >>> I think at this point 3.9.0 has to go through. At the very least we >>> should make sure it's clearly explained, I didn't see anything about >>> this limitation in our docs or release notes. >>> >>> Anyway, thanks for the new RC, I plan to test it tomorrow. >>> >>> Thanks, >>> Mickael >>> >>> >>> On Thu, Oct 24, 2024 at 7:49 PM Colin McCabe <cmcc...@apache.org> wrote: >>> > >>> > Hi Luke, >>> > >>> > Unfortunately, we don't have a way to upgrade from static quorums to >>> dynamic quorums yet. We are hoping to include this in the next release. >>> We're trakcing it under https://issues.apache.org/jira/browse/KAFKA-16538 >>> . >>> > >>> > best, >>> > Colin >>> > >>> > >>> > On Thu, Oct 24, 2024, at 05:25, Luke Chen wrote: >>> > > Hi Colin, >>> > > >>> > > I found I cannot upgrade to v3.9.0 and then successfully add a new >>> > > controller or remove a controller. I've opened KAFKA-17866 >>> > > <https://issues.apache.org/jira/browse/KAFKA-17866>. Please take a >>> look. >>> > > >>> > > Thanks. >>> > > Luke >>> > > >>> > > On Thu, Oct 24, 2024 at 2:27 PM TengYao Chi <kiting...@gmail.com> >>> wrote: >>> > > >>> > >> Hi Colin, >>> > >> >>> > >> Thanks for handling the release of the new RC. >>> > >> >>> > >> I built from source and ran all the unit and integration tests on >>> each >>> > >> combination of different LTS JDK versions and distributions in >>> Docker (Zulu >>> > >> and Corretto). >>> > >> >>> > >> +1 (non-binding) >>> > >> >>> > >> Thanks, >>> > >> TengYao >>> > >> >>> > >> Justine Olshan <jols...@confluent.io.invalid> 於 2024年10月24日 週四 >>> 下午2:24寫道： >>> > >> >>> > >> > Hey Colin, >>> > >> > >>> > >> > Thanks for running the release. >>> > >> > >>> > >> > I checked the keys and scanned the docs >>> > >> > I built from source, used kraft quickstart, ran a transactions >>> workload, >>> > >> > played around with a few other things including running some of the >>> > >> feature >>> > >> > version commands. >>> > >> > >>> > >> > I noticed that some of the KIP-1022 work that was meant to make it >>> in >>> > >> this >>> > >> > release was removed. >>> > >> > Without any specifications, the cluster is meant to take the latest >>> > >> version >>> > >> > of all available features. The code to do that was removed. >>> Perhaps there >>> > >> > is a reason, but we should either change the KIP or remedy this. >>> > >> > Not only that, but the ability to configure a feature via the >>> --feature >>> > >> > flag in the storage tool also seems to be removed but the text >>> remains >>> > >> when >>> > >> > running with no arguments. I don't think it is a blocker, but this >>> should >>> > >> > be fixed for 4.0. >>> > >> > >>> > >> > I looked at two runs of the system tests and they looked fine to >>> me. >>> > >> > >>> > >> > +1 (binding) from me, >>> > >> > >>> > >> > Justine >>> > >> > >>> > >> > On Tue, Oct 22, 2024 at 1:21 PM Bill Bejeck <bbej...@apache.org> >>> wrote: >>> > >> > >>> > >> > > Hi Colin, >>> > >> > > >>> > >> > > Thanks for running the release. >>> > >> > > >>> > >> > > I did the following verification steps: >>> > >> > > >>> > >> > > 1. Built from source >>> > >> > > 2. Validated all checksums >>> > >> > > 3. Ran all the unit tests >>> > >> > > 4. Pulled both docker images and started up Kafka >>> > >> > > 5. Ran the KRaft quick start >>> > >> > > 6. Ran the ZK quick start >>> > >> > > 7. Ran the Kafka Streams quick start >>> > >> > > 8. Spot checked the documentation >>> > >> > > 9. Spot checked the javadocs >>> > >> > > >>> > >> > > +1(binding) >>> > >> > > >>> > >> > > Thanks, >>> > >> > > Bill >>> > >> > > >>> > >> > > >>> > >> > > >>> > >> > > On Tue, Oct 22, 2024 at 9:08 AM Federico Valeri < >>> fedeval...@gmail.com> >>> > >> > > wrote: >>> > >> > > >>> > >> > > > Hi, I did the following tests: >>> > >> > > > >>> > >> > > > - Ran all unit and integration tests >>> > >> > > > - Spot checked the documentation >>> > >> > > > - Tried out new Maven dependencies >>> > >> > > > - Tested KIP-853, KIP-950, KIP-956 and KIP-1057 >>> > >> > > > >>> > >> > > > +1 (non binding) >>> > >> > > > >>> > >> > > > Thanks >>> > >> > > > Fede >>> > >> > > > >>> > >> > > > >>> > >> > > > On Mon, Oct 21, 2024 at 11:12 PM Colin McCabe < >>> cmcc...@apache.org> >>> > >> > > wrote: >>> > >> > > > > >>> > >> > > > > This is the third candidate for the release of Apache Kafka >>> 3.9.0. >>> > >> I >>> > >> > > > have titled it rc3 since I had an rc1 which got very far, even >>> to the >>> > >> > > point >>> > >> > > > of pushing tags and docker images, before I spotted an issue. >>> So >>> > >> rather >>> > >> > > > than mutate the tags, I decided to skip over rc1. >>> > >> > > > > >>> > >> > > > > - This is a major release, the final one in the 3.x line. >>> (There >>> > >> may >>> > >> > of >>> > >> > > > course be other minor releases in this line, such as 3.9.1.) >>> > >> > > > > - Tiered storage will be considered production-ready in this >>> > >> release. >>> > >> > > > > - This will be the final major release to feature the >>> deprecated >>> > >> > > > ZooKeeper mode. >>> > >> > > > > >>> > >> > > > > This release includes the following KIPs: >>> > >> > > > > - KIP-853: Support dynamically changing KRaft controller >>> membership >>> > >> > > > > - KIP-1057: Add remote log metadata flag to the dump log tool >>> > >> > > > > - KIP-1049: Add config log.summary.interval.ms to Kafka >>> Streams >>> > >> > > > > - KIP-1040: Improve handling of nullable values in >>> InsertField, >>> > >> > > > ExtractField, and other transformations >>> > >> > > > > - KIP-1031: Control offset translation in >>> MirrorSourceConnector >>> > >> > > > > - KIP-1033: Add Kafka Streams exception handler for >>> exceptions >>> > >> > > occurring >>> > >> > > > during processing >>> > >> > > > > - KIP-1017: Health check endpoint for Kafka Connect >>> > >> > > > > - KIP-1025: Optionally URL-encode clientID and clientSecret >>> in >>> > >> > > > authorization header >>> > >> > > > > - KIP-1005: Expose EarliestLocalOffset and TieredOffset >>> > >> > > > > - KIP-950: Tiered Storage Disablement >>> > >> > > > > - KIP-956: Tiered Storage Quotas >>> > >> > > > > >>> > >> > > > > Release notes for the 3.9.0 release: >>> > >> > > > > >>> > >> > > > >>> > >> > > >>> > >> > >>> > >> >>> https://dist.apache.org/repos/dist/dev/kafka/3.9.0-rc3/RELEASE_NOTES.html >>> > >> > > > > >>> > >> > > > > *** Please download, test and vote by October 24, 2024. >>> > >> > > > > >>> > >> > > > > Kafka's KEYS file containing PGP keys we use to sign the >>> release: >>> > >> > > > > https://kafka.apache.org/KEYS >>> > >> > > > > >>> > >> > > > > * Release artifacts to be voted upon (source and binary): >>> > >> > > > > https://dist.apache.org/repos/dist/dev/kafka/3.9.0-rc3/ >>> > >> > > > > >>> > >> > > > > * Docker release artifacts to be voted upon: >>> > >> > > > > apache/kafka:3.9.0-rc3 >>> > >> > > > > apache/kafka-native:3.9.0-rc3 >>> > >> > > > > >>> > >> > > > > * Maven artifacts to be voted upon: >>> > >> > > > > >>> > >> > >>> https://repository.apache.org/content/groups/staging/org/apache/kafka/ >>> > >> > > > > >>> > >> > > > > * Javadoc: >>> > >> > > > > >>> https://dist.apache.org/repos/dist/dev/kafka/3.9.0-rc3/javadoc/ >>> > >> > > > > >>> > >> > > > > * Documentation: >>> > >> > > > > https://kafka.apache.org/39/documentation.html >>> > >> > > > > >>> > >> > > > > * Protocol: >>> > >> > > > > https://kafka.apache.org/39/protocol.html >>> > >> > > > > >>> > >> > > > > * Tag to be voted upon (off 3.9 branch) is the 3.9.0-rc3 tag: >>> > >> > > > > https://github.com/apache/kafka/releases/tag/3.9.0-rc3 >>> > >> > > > > >>> > >> > > > > * Successful Docker Image Github Actions Pipeline for 3.9 >>> branch: >>> > >> > > > > Docker Build Test Pipeline (JVM): >>> > >> > > > https://github.com/apache/kafka/actions/runs/11448325059 >>> > >> > > > > Docker Build Test Pipeline (Native): >>> > >> > > > https://github.com/apache/kafka/actions/runs/11448338981 >>> > >> > > > > >>> > >> > > > > Thanks to everyone who helped with this release candidate, >>> either >>> > >> by >>> > >> > > > contributing code, testing, or documentation. >>> > >> > > > > >>> > >> > > > > Regards, >>> > >> > > > > Colin >>> > >> > > > >>> > >> > > >>> > >> > >>> > >> >>> >>
