Re: [DISCUSS] KIP-436 Add a metric indicating start time

2019-03-05 Thread Stanislav Kozlovski
Thanks for the discussion, folks. I'll be starting a vote thread now. Dongjin, thanks for updating the link to the discussion thread. Best, Stanislav On Sun, Mar 3, 2019 at 1:30 PM Manikumar wrote: > Hi Stanislav, > > I too don't have strong preference between both the metrics. > Adding `start

Re: [DISCUSS] KIP-436 Add a metric indicating start time

2019-03-03 Thread Manikumar
Hi Stanislav, I too don't have strong preference between both the metrics. Adding `startTime` metric is reasonable to me. Thanks, Manikumar

Re: [DISCUSS] KIP-436 Add a metric indicating start time

2019-03-03 Thread Dongjin Lee
Hi Stanislav, Sorry for being late. I feel this proposal is reasonable. Add to this, I made a trivial revision to your KIP - I updated the link to discussion thread. Thanks, Dongjin On Sun, Mar 3, 2019 at 5:08 AM Stanislav Kozlovski wrote: > Hello everybody, > > It's been a week since this KIP

Re: [DISCUSS] KIP-436 Add a metric indicating start time

2019-03-02 Thread Stanislav Kozlovski
Hello everybody, It's been a week since this KIP was first posted and not much discussion has been had. I can only assume people find the new metric somewhat reasonable. I will consider starting a voting thread after a couple of days if nobody has objections. @Manikumar, Do you have any further t

Re: [DISCUSS] KIP-436 Add a metric indicating start time

2019-02-24 Thread Stanislav Kozlovski
Hello Manikumar, I am not sure if there is value in having both `upTime` and `startTime` metrics, as one can be derived from the other. The question to me is which one we should have - I had considered `upTime` as well; I don't have a strong preference in between both in all honesty. I thought sin

Re: [DISCUSS] KIP-436 Add a metric indicating start time

2019-02-24 Thread Manikumar
Thanks for the KIP. looks good to me. How about adding metric for upTime also? On Sun, Feb 24, 2019 at 1:21 PM Stanislav Kozlovski wrote: > Hey everybody, > > I'd like to start a discussion about a simple change - adding a metric > indicating the time at which the Kafka application has started.

[DISCUSS] KIP-436 Add a metric indicating start time

2019-02-23 Thread Stanislav Kozlovski
Hey everybody, I'd like to start a discussion about a simple change - adding a metric indicating the time at which the Kafka application has started. KIP: KIP-436 JIRA: KAFKA-7992