Hello Manikumar, I am not sure if there is value in having both `upTime` and `startTime` metrics, as one can be derived from the other. The question to me is which one we should have - I had considered `upTime` as well; I don't have a strong preference in between both in all honesty. I thought since they're more or less equal to one another, `startTime` would be simpler and more performant to return (no computation done on server/client)
On Sun, Feb 24, 2019 at 8:17 AM Manikumar <manikumar.re...@gmail.com> wrote: > Thanks for the KIP. looks good to me. > How about adding metric for upTime also? > > On Sun, Feb 24, 2019 at 1:21 PM Stanislav Kozlovski < > stanis...@confluent.io> > wrote: > > > Hey everybody, > > > > I'd like to start a discussion about a simple change - adding a metric > > indicating the time at which the Kafka application has started. > > > > KIP: KIP-436 > > < > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-436%3A+Add+a+metric+indicating+start+time > > > > > JIRA: KAFKA-7992 <https://issues.apache.org/jira/browse/KAFKA-7992> > > Pull Request: 6318 <https://github.com/apache/kafka/pull/6318> > > > > I look forward to seeing people's thoughts. > > > > -- > > Best, > > Stanislav > > > -- Best, Stanislav