Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

Hi Matthias Thank you again for previous suggestion. I will start a VOTE soon. Best regards, TengYao Matthias J. Sax 於 2024年8月22日 週四 下午12:02寫道： > I think the KIP is fine as-is. > > Seems it's also not very controversial. Feel free to start a VOTE. > > > -Matthias > > On 8/6/24 7:54 PM, TengYao

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

I think the KIP is fine as-is. Seems it's also not very controversial. Feel free to start a VOTE. -Matthias On 8/6/24 7:54 PM, TengYao Chi wrote: Hi Matthias, Thank you for pointing that out. I will keep it in mind. Do I need to update the content of the KIP, or can we leave it as is? Best r

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

Hi Matthias, Thank you for pointing that out. I will keep it in mind. Do I need to update the content of the KIP, or can we leave it as is? Best regards, TengYao Matthias J. Sax 於 2024年8月7日 週三 上午10:45寫道： > I have already an open PR for the internal cleanup: > https://github.com/apache/kafka/pul

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

I have already an open PR for the internal cleanup: https://github.com/apache/kafka/pull/14551 While I did this cleanup, I filed the Jira for the necessary public changes. Did not expect that the KIP would get picked up so quickly :) In general, a KIP should only concern itself with public AP

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

I just trace these code, I think this proposal is clear enough. > Kuan Po Tseng 於 2024年8月5日 凌晨12:45 寫道： > > Thank you ! LGTM ! > > Best regards, > Kuan-Po Tseng > > On 2024/08/04 16:40:12 TengYao Chi wrote: >> Hello Kuan Po >> >> I just reviewed the code, and you are right. >> >> Currently,

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

Thank you ! LGTM ! Best regards, Kuan-Po Tseng On 2024/08/04 16:40:12 TengYao Chi wrote: > Hello Kuan Po > > I just reviewed the code, and you are right. > > Currently, Joined#gracePeriod is not in the JoinedInternal. I will slightly > modify the content of the KIP to avoid any misunderstanding

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

Hello Kuan Po I just reviewed the code, and you are right. Currently, Joined#gracePeriod is not in the JoinedInternal. I will slightly modify the content of the KIP to avoid any misunderstandings. Thanks for pointing it out. Best Regards, TengYao Kuan Po Tseng 於 2024年8月5日 週一 上午12:30寫道： > Th

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

Thank you for the nice KIP ! About deprecating Joined#gracePeriod, did you mean we should move the Joined#gracePeriod to JoinedInternal class as I didn't see the corresponding method in JoinedInternal you mentioned. Best regards, Kuan-Po Tseng On 2024/08/04 16:13:31 TengYao Chi wrote: > Hello

[DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

Hello everyone, I would like to start a discussion about KIP-1078 . We plan to deprecate the four public APIs in *org.apache.kafka.streams.kstream.Joined* that already have internal