Thank you ! LGTM ! Best regards, Kuan-Po Tseng
On 2024/08/04 16:40:12 TengYao Chi wrote: > Hello Kuan Po > > I just reviewed the code, and you are right. > > Currently, Joined#gracePeriod is not in the JoinedInternal. I will slightly > modify the content of the KIP to avoid any misunderstandings. > > > Thanks for pointing it out. > > Best Regards, > TengYao > > Kuan Po Tseng <brandb...@apache.org> 於 2024年8月5日 週一 上午12:30寫道： > > > Thank you for the nice KIP ! > > > > About deprecating Joined#gracePeriod, did you mean we should move the > > Joined#gracePeriod to JoinedInternal class as I didn't see the > > corresponding method in JoinedInternal you mentioned. > > > > Best regards, > > > > Kuan-Po Tseng > > > > On 2024/08/04 16:13:31 TengYao Chi wrote: > > > Hello everyone, > > > > > > > > > I would like to start a discussion about KIP-1078 > > > < > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1078%3A+Remove+Leaking+Getter+Methods+in+Joined+Helper+Class > > >. > > > We plan to deprecate the four public APIs in > > > *org.apache.kafka.streams.kstream.Joined* that already have internal > > > versions and are intended for internal use only. > > > > > > > > > Please take a look, and if you have any suggestions or thoughts, feel > > free > > > to reply to this email thread. > > > > > > Thank you! > > > > > > Best regards, > > > TengYao > > > > > >
