Hi Matthias, Thank you for pointing that out. I will keep it in mind. Do I need to update the content of the KIP, or can we leave it as is?
Best regards, TengYao Matthias J. Sax <mj...@apache.org> 於 2024年8月7日 週三 上午10:45寫道： > I have already an open PR for the internal cleanup: > https://github.com/apache/kafka/pull/14551 > > While I did this cleanup, I filed the Jira for the necessary public > changes. Did not expect that the KIP would get picked up so quickly :) > > In general, a KIP should only concern itself with public API changes, > and thus, does not need to mention internal changes. > > > -Matthias > > On 8/4/24 5:50 PM, 黃竣陽 wrote: > > I just trace these code, I think this proposal is clear enough. > > > >> Kuan Po Tseng <brandb...@apache.org> 於 2024年8月5日 凌晨12:45 寫道： > >> > >> Thank you ! LGTM ! > >> > >> Best regards, > >> Kuan-Po Tseng > >> > >> On 2024/08/04 16:40:12 TengYao Chi wrote: > >>> Hello Kuan Po > >>> > >>> I just reviewed the code, and you are right. > >>> > >>> Currently, Joined#gracePeriod is not in the JoinedInternal. I will > slightly > >>> modify the content of the KIP to avoid any misunderstandings. > >>> > >>> > >>> Thanks for pointing it out. > >>> > >>> Best Regards, > >>> TengYao > >>> > >>> Kuan Po Tseng <brandb...@apache.org> 於 2024年8月5日 週一 上午12:30寫道： > >>> > >>>> Thank you for the nice KIP ! > >>>> > >>>> About deprecating Joined#gracePeriod, did you mean we should move the > >>>> Joined#gracePeriod to JoinedInternal class as I didn't see the > >>>> corresponding method in JoinedInternal you mentioned. > >>>> > >>>> Best regards, > >>>> > >>>> Kuan-Po Tseng > >>>> > >>>> On 2024/08/04 16:13:31 TengYao Chi wrote: > >>>>> Hello everyone, > >>>>> > >>>>> > >>>>> I would like to start a discussion about KIP-1078 > >>>>> < > >>>> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1078%3A+Remove+Leaking+Getter+Methods+in+Joined+Helper+Class > >>>>> . > >>>>> We plan to deprecate the four public APIs in > >>>>> *org.apache.kafka.streams.kstream.Joined* that already have internal > >>>>> versions and are intended for internal use only. > >>>>> > >>>>> > >>>>> Please take a look, and if you have any suggestions or thoughts, feel > >>>> free > >>>>> to reply to this email thread. > >>>>> > >>>>> Thank you! > >>>>> > >>>>> Best regards, > >>>>> TengYao > >>>>> > >>>> > >>> > > >
