[jira] [Commented] (KAFKA-291) Add builder to create configs for consumer and broker

2013-12-30 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859341#comment-13859341 ] Swapnil Ghike commented on KAFKA-291: - Not sure if the ConfigBuilder is goin

Re: Review Request 16022: OfflinePartitionCount in JMX can be incorrect during controlled shutdown

2013-12-04 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16022/#review29776 --- Ship it! Ship It! - Swapnil Ghike On Dec. 4, 2013, 11:42 p.m

[jira] [Updated] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-12-03 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1152: - Attachment: incremental.patch Attached a patch to fix logging statement. > ReplicaManage

Re: Review Request 15901: Patch for KAFKA-1152

2013-12-02 Thread Swapnil Ghike
-------- On Nov. 29, 2013, 6:41 a.m., Swapnil Ghike wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15901/ > -

[jira] [Updated] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1152: - Attachment: (was: KAFKA-1152.patch) > ReplicaManager's handling of the leaderAndIs

[jira] [Commented] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835205#comment-13835205 ] Swapnil Ghike commented on KAFKA-1152: -- Updated reviewboard h

[jira] [Updated] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1152: - Attachment: KAFKA-1152_2013-11-28_22:40:55.patch > ReplicaManager's handlin

Re: Review Request 15901: Patch for KAFKA-1152

2013-11-28 Thread Swapnil Ghike
ader == -1 Diffs (updated) - core/src/main/scala/kafka/server/ReplicaManager.scala 161f58134f20f9335dbd2bee6ac3f71897cbef7c Diff: https://reviews.apache.org/r/15901/diff/ Testing --- Builds with all scala versions; unit tests pass Thanks, Swapnil Ghike

[jira] [Updated] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1152: - Attachment: KAFKA-1152.patch > ReplicaManager's handling of the leaderAndIsrReques

[jira] [Commented] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835198#comment-13835198 ] Swapnil Ghike commented on KAFKA-1152: -- Created reviewboard h

Review Request 15915: Patch for KAFKA-1152

2013-11-28 Thread Swapnil Ghike
fka/server/ReplicaManager.scala 161f58134f20f9335dbd2bee6ac3f71897cbef7c Diff: https://reviews.apache.org/r/15915/diff/ Testing --- Thanks, Swapnil Ghike

[jira] [Commented] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835022#comment-13835022 ] Swapnil Ghike commented on KAFKA-1152: -- Updated reviewboard h

[jira] [Updated] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1152: - Attachment: KAFKA-1152_2013-11-28_10:19:05.patch > ReplicaManager's handlin

Re: Review Request 15901: Patch for KAFKA-1152

2013-11-28 Thread Swapnil Ghike
scala/kafka/server/ReplicaManager.scala 161f58134f20f9335dbd2bee6ac3f71897cbef7c Diff: https://reviews.apache.org/r/15901/diff/ Testing --- Builds with all scala versions; unit tests pass Thanks, Swapnil Ghike

Re: Review Request 15901: ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-27 Thread Swapnil Ghike
scala 161f58134f20f9335dbd2bee6ac3f71897cbef7c Diff: https://reviews.apache.org/r/15901/diff/ Testing (updated) --- Builds with all scala versions; unit tests pass Thanks, Swapnil Ghike

[jira] [Updated] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-27 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1152: - Attachment: KAFKA-1152.patch > ReplicaManager's handling of the leaderAndIsrReques

[jira] [Commented] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-27 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13834544#comment-13834544 ] Swapnil Ghike commented on KAFKA-1152: -- Created reviewboard h

Review Request 15901: ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-27 Thread Swapnil Ghike
e.org/r/15901/diff/ Testing --- Builds Thanks, Swapnil Ghike

[jira] [Created] (KAFKA-1152) ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

2013-11-27 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-1152: Summary: ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1 Key: KAFKA-1152 URL: https://issues.apache.org/jira/browse/KAFKA

[jira] [Commented] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-25 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832040#comment-13832040 ] Swapnil Ghike commented on KAFKA-1135: -- [~jjkoshy], does the above issue

[jira] [Commented] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-25 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832037#comment-13832037 ] Swapnil Ghike commented on KAFKA-1135: -- Thanks for catching this David! Jun

Re: Review Request 15711: Patch for KAFKA-930

2013-11-20 Thread Swapnil Ghike
57> Will it be simpler to have a per cluster config instead of a per broker config? i cant think of any downsides. - Swapnil Ghike On Nov. 20, 2013, 1:38 a.m., Sriram Subramanian wrote: > > --- > This is an automati

[jira] [Commented] (KAFKA-1117) tool for checking the consistency among replicas

2013-11-20 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828146#comment-13828146 ] Swapnil Ghike commented on KAFKA-1117: -- Hey Jun, after committing this patch, bu

Re: Review Request 15665: Patch for KAFKA-1135

2013-11-19 Thread Swapnil Ghike
ble, so that when we > > upgrade in the future we only need to upgrade in once place? > > Swapnil Ghike wrote: > My understanding was that the code may evolve to deal with situations > wherein we have some zookeeper paths that are on version n, and others are on > ver

Re: Review Request 15665: Patch for KAFKA-1135

2013-11-19 Thread Swapnil Ghike
automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15665/#review29116 ------- On Nov. 19, 2013, 3:21 a.m., Swapnil Ghike wrote: > > --- > This is an automatically ge

[jira] [Commented] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826133#comment-13826133 ] Swapnil Ghike commented on KAFKA-1135: -- Updated reviewboard h

[jira] [Updated] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1135: - Attachment: KAFKA-1135_2013-11-18_19:20:58.patch > Code cleanup - use Json.encode() to wr

Re: Review Request 15665: Patch for KAFKA-1135

2013-11-18 Thread Swapnil Ghike
defined in https://cwiki.apache.org/confluence/display/KAFKA/Kafka+data+structures+in+Zookeeper Thanks, Swapnil Ghike

[jira] [Commented] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826128#comment-13826128 ] Swapnil Ghike commented on KAFKA-1135: -- Updated reviewboard h

Re: Review Request 15665: Patch for KAFKA-1135

2013-11-18 Thread Swapnil Ghike
zookeeper data looks like the structures defined in https://cwiki.apache.org/confluence/display/KAFKA/Kafka+data+structures+in+Zookeeper Thanks, Swapnil Ghike

[jira] [Updated] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1135: - Attachment: KAFKA-1135_2013-11-18_19:17:54.patch > Code cleanup - use Json.encode() to wr

[jira] [Updated] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1135: - Attachment: KAFKA-1135.patch > Code cleanup - use Json.encode() to write json data to

Re: Review Request 15665: Code clean: use Json.encode() to write json data to zookeeper

2013-11-18 Thread Swapnil Ghike
://cwiki.apache.org/confluence/display/KAFKA/Kafka+data+structures+in+Zookeeper Thanks, Swapnil Ghike

[jira] [Commented] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826116#comment-13826116 ] Swapnil Ghike commented on KAFKA-1135: -- Created reviewboard h

Review Request 15665: Code clean: use Json.encode() to write json data to zookeeper

2013-11-18 Thread Swapnil Ghike
c9ca95f1937d0ef2e64c70e4d811a0d4f358d9db core/src/main/scala/kafka/utils/ZkUtils.scala 856d13605b0b4bf86010571eacbacc0fb0ba7950 Diff: https://reviews.apache.org/r/15665/diff/ Testing --- Verified Thanks, Swapnil Ghike

[jira] [Created] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-1135: Summary: Code cleanup - use Json.encode() to write json data to zk Key: KAFKA-1135 URL: https://issues.apache.org/jira/browse/KAFKA-1135 Project: Kafka

Re: Review Request 15201: address all review comments

2013-11-14 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15201/#review28873 --- Ship it! Ship It! - Swapnil Ghike On Nov. 14, 2013, 4:24 p.m

Re: Review Request 15201: address more review comments

2013-11-12 Thread Swapnil Ghike
#comment55809> typo Another caveat seems to be that the tool cannot handle changes in 1. partition leadership change 2. topic configuration change (number of partitions). - Swapnil Ghike On Nov. 12, 2013, 4:34 p.m., Jun Rao wrote: > >

Re: Review Request 15274: Patch for KAFKA-1119

2013-11-07 Thread Swapnil Ghike
tps://reviews.apache.org/r/15274/#comment55256> Should we enforce that configsToBeAdded and configsToBeDeleted should not contain the same config? - Swapnil Ghike On Nov. 7, 2013, 6:17 p.m., Neha Narkhede wrote: > > ---

Re: Review Request 15274: Patch for KAFKA-1119

2013-11-06 Thread Swapnil Ghike
--config config1=newVal --deleteConfig config2. - Swapnil Ghike On Nov. 6, 2013, 6:13 p.m., Neha Narkhede wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

[jira] [Commented] (KAFKA-1121) DumpLogSegments tool should print absolute file name to report inconsistencies

2013-11-05 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814308#comment-13814308 ] Swapnil Ghike commented on KAFKA-1121: -- Created reviewboard h

[jira] [Updated] (KAFKA-1121) DumpLogSegments tool should print absolute file name to report inconsistencies

2013-11-05 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1121: - Attachment: KAFKA-1121.patch > DumpLogSegments tool should print absolute file name to rep

Review Request 15248: DumpLogSegments should print absolute file path while printing errors

2013-11-05 Thread Swapnil Ghike
/browse/KAFKA-1121 Repository: kafka Description --- dumplogseg Diffs - core/src/main/scala/kafka/tools/DumpLogSegments.scala 89b6cb1d0c3d9a1335184d0fc778246ce47738d3 Diff: https://reviews.apache.org/r/15248/diff/ Testing --- Thanks, Swapnil Ghike

[jira] [Updated] (KAFKA-1121) DumpLogSegments tool should print absolute file name to report inconsistencies

2013-11-05 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1121: - Fix Version/s: 0.8.1 > DumpLogSegments tool should print absolute file name to rep

[jira] [Updated] (KAFKA-1121) DumpLogSegments tool should print absolute file name to report inconsistencies

2013-11-05 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1121: - Affects Version/s: 0.8 > DumpLogSegments tool should print absolute file name to rep

[jira] [Created] (KAFKA-1121) DumpLogSegments tool should print absolute file name to report inconsistencies

2013-11-05 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-1121: Summary: DumpLogSegments tool should print absolute file name to report inconsistencies Key: KAFKA-1121 URL: https://issues.apache.org/jira/browse/KAFKA-1121 Project

Re: Review Request 15137: Patch for KAFKA-1107

2013-10-31 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15137/#review27989 --- Ship it! Ship It! - Swapnil Ghike On Oct. 31, 2013, 10:28 p.m

Re: Review Request 15137: Patch for KAFKA-1107

2013-10-31 Thread Swapnil Ghike
tps://reviews.apache.org/r/15137/#comment5> probably don't need this statement. - Swapnil Ghike On Oct. 31, 2013, 10:28 p.m., Neha Narkhede wrote: > > --- > This is an automatically generated e-mail. To r

[jira] [Comment Edited] (KAFKA-918) Change log.retention.hours to be log.retention.mins

2013-10-25 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805392#comment-13805392 ] Swapnil Ghike edited comment on KAFKA-918 at 10/25/13 3:4

[jira] [Commented] (KAFKA-918) Change log.retention.hours to be log.retention.mins

2013-10-25 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805392#comment-13805392 ] Swapnil Ghike commented on KAFKA-918: - I think it's confusing to allow both c

[jira] [Commented] (KAFKA-1100) metrics shouldn't have generation/timestamp specific names

2013-10-23 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803660#comment-13803660 ] Swapnil Ghike commented on KAFKA-1100: -- That makes sense Joel, we could also use

[jira] [Commented] (KAFKA-1100) metrics shouldn't have generation/timestamp specific names

2013-10-22 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802635#comment-13802635 ] Swapnil Ghike commented on KAFKA-1100: -- Hi Jason, at LinkedIn, we use wildc

[jira] [Created] (KAFKA-1096) An old controller coming out of long GC could update its epoch to the latest controller's epoch

2013-10-21 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-1096: Summary: An old controller coming out of long GC could update its epoch to the latest controller's epoch Key: KAFKA-1096 URL: https://issues.apache.org/jira/browse/KAFKA

[jira] [Commented] (KAFKA-1094) Configure reviewboard url in kafka-patch-review tool

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800024#comment-13800024 ] Swapnil Ghike commented on KAFKA-1094: -- Same patch will work for trunk. > Co

[jira] [Commented] (KAFKA-1094) Configure reviewboard url in kafka-patch-review tool

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800023#comment-13800023 ] Swapnil Ghike commented on KAFKA-1094: -- Created reviewboard h

[jira] [Updated] (KAFKA-1094) Configure reviewboard url in kafka-patch-review tool

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1094: - Attachment: KAFKA-1094.patch > Configure reviewboard url in kafka-patch-review t

[jira] [Created] (KAFKA-1094) Configure reviewboard url in kafka-patch-review tool

2013-10-19 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-1094: Summary: Configure reviewboard url in kafka-patch-review tool Key: KAFKA-1094 URL: https://issues.apache.org/jira/browse/KAFKA-1094 Project: Kafka Issue

Review Request 14773: Configure reviewboard url in kafka-patch-review tool

2013-10-19 Thread Swapnil Ghike
/browse/KAFKA-1094 Repository: kafka Description --- configure reviewboard Diffs - kafka-patch-review.py 2653465a30a0084cbd37fa07d00e07134ef3bd7f Diff: https://reviews.apache.org/r/14773/diff/ Testing --- Thanks, Swapnil Ghike

[jira] [Updated] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Attachment: (was: KAFKA-1093.patch) > Log.getOffsetsBefore(t, …) does not return the l

[jira] [Commented] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800021#comment-13800021 ] Swapnil Ghike commented on KAFKA-1093: -- Created reviewboard h

[jira] [Updated] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Attachment: KAFKA-1093.patch > Log.getOffsetsBefore(t, …) does not return the last confir

[jira] [Issue Comment Deleted] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Comment: was deleted (was: Created reviewboard https://reviews.apache.org/r/14772

Review Request 14772: Configure reviewboard url in kafka-patch-review tool

2013-10-19 Thread Swapnil Ghike
/browse/KAFKA-1093 Repository: kafka Description --- configure reviewboard Diffs - kafka-patch-review.py 2653465a30a0084cbd37fa07d00e07134ef3bd7f Diff: https://reviews.apache.org/r/14772/diff/ Testing --- Thanks, Swapnil Ghike

[jira] [Issue Comment Deleted] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Comment: was deleted (was: Created reviewboard ) > Log.getOffsetsBefore(t, …) does not ret

[jira] [Updated] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Attachment: (was: KAFKA-1093.patch) > Log.getOffsetsBefore(t, …) does not return the l

Re: Review Request 14771: Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike
://reviews.apache.org/r/14771/diff/ Testing (updated) --- Unit tests pass. Thanks, Swapnil Ghike

[jira] [Updated] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Attachment: KAFKA-1093.patch > Log.getOffsetsBefore(t, …) does not return the last confir

[jira] [Commented] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800018#comment-13800018 ] Swapnil Ghike commented on KAFKA-1093: -- Created reviewboard h

Review Request 14771: Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike
--- Thanks, Swapnil Ghike

[jira] [Updated] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Attachment: KAFKA-1093.patch > Log.getOffsetsBefore(t, …) does not return the last confir

[jira] [Commented] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800013#comment-13800013 ] Swapnil Ghike commented on KAFKA-1093: -- Created reviewboard > Log.getOffset

[jira] [Updated] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Description: Let's say there are three log segments s1, s2, s3. In Log.getoffsetsBef

[jira] [Created] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-1093: Summary: Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t Key: KAFKA-1093 URL: https://issues.apache.org/jira/browse/KAFKA-1093 Project

[jira] [Updated] (KAFKA-1093) Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

2013-10-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1093: - Affects Version/s: 0.8 > Log.getOffsetsBefore(t, …) does not return the last confirmed off

Re: Review Request 14676: Patch for KAFKA-1091

2013-10-16 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14676/#review27072 --- Ship it! Ship It! - Swapnil Ghike On Oct. 16, 2013, 5:19 p.m

[jira] [Commented] (KAFKA-1087) Empty topic list causes consumer to fetch metadata of all topics

2013-10-15 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794966#comment-13794966 ] Swapnil Ghike commented on KAFKA-1087: -- Same patch should apply fine to t

[jira] [Updated] (KAFKA-1087) Empty topic list causes consumer to fetch metadata of all topics

2013-10-14 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1087: - Description: The ClientUtils fetches metadata for all topics if the topic set is empty. If the

[jira] [Updated] (KAFKA-1087) Empty topic list causes consumer to fetch metadata of all topics

2013-10-14 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1087: - Description: The ClientUtils fetches metadata for all topics if the topic set is empty. If the

[jira] [Updated] (KAFKA-1087) Empty topic list causes consumer to fetch metadata of all topics

2013-10-14 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1087: - Attachment: KAFKA-1087.patch Unit tests pass. > Empty topic list causes consumer to fe

[jira] [Updated] (KAFKA-1087) Empty topic list causes consumer to fetch metadata of all topics

2013-10-14 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1087: - Affects Version/s: 0.8 > Empty topic list causes consumer to fetch metadata of all top

[jira] [Created] (KAFKA-1087) Empty topic list causes consumer to fetch metadata of all topics

2013-10-14 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-1087: Summary: Empty topic list causes consumer to fetch metadata of all topics Key: KAFKA-1087 URL: https://issues.apache.org/jira/browse/KAFKA-1087 Project: Kafka

Re: Review Request 14496: incorporating review feedback

2013-10-06 Thread Swapnil Ghike
<https://reviews.apache.org/r/14496/#comment52036> Instead of asking the user to store the output of a dryrun into a JSON file, should the tool compute the dryrun output and use it to perform validation ? - Swapnil Ghike On Oct. 5, 2013, 6:02 p.m., Jun Rao

Re: Review Request 14496: Patch for KAFKA-1073

2013-10-04 Thread Swapnil Ghike
ReassignPartitions tool itself with a "checkStatus" mode make sense in trunk? - Swapnil Ghike On Oct. 4, 2013, 9:33 p.m., Jun Rao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

[jira] [Commented] (KAFKA-1030) Addition of partitions requires bouncing all the consumers of that topic

2013-09-17 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769884#comment-13769884 ] Swapnil Ghike commented on KAFKA-1030: -- +1 that Guozhang, thanks for running

Re: Review Request 14041: Patch for KAFKA-1030

2013-09-17 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14041/#review26179 --- Ship it! Ship It! - Swapnil Ghike On Sept. 17, 2013, 6 p.m

[jira] [Issue Comment Deleted] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

2013-09-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1003: - Comment: was deleted (was: Created reviewboard https://reviews.apache.org/r/14161

[jira] [Commented] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

2013-09-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768778#comment-13768778 ] Swapnil Ghike commented on KAFKA-1003: -- Created reviewboard h

[jira] [Updated] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

2013-09-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1003: - Attachment: (was: KAFKA-1003.patch) > ConsumerFetcherManager should pass clientId

[jira] [Updated] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

2013-09-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1003: - Attachment: KAFKA-1003.patch > ConsumerFetcherManager should pass clientId as metricsPre

Review Request 14161: Patch for KAFKA-1003

2013-09-16 Thread Swapnil Ghike
/browse/KAFKA-1003 Repository: kafka Description --- test Diffs - core/src/main/scala/kafka/producer/ProducerConfig.scala 7947b18aceb297f51adc0edcb1a11a447ca83e5f Diff: https://reviews.apache.org/r/14161/diff/ Testing --- Thanks, Swapnil Ghike

[jira] [Updated] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

2013-09-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1003: - Attachment: (was: KAFKA-1003.patch) > ConsumerFetcherManager should pass clientId

[jira] [Updated] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

2013-09-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1003: - Attachment: (was: KAFKA-1003.patch) > ConsumerFetcherManager should pass clientId

[jira] [Updated] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

2013-09-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1003: - Attachment: KAFKA-1003.patch > ConsumerFetcherManager should pass clientId as metricsPre

[jira] [Commented] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

2013-09-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768770#comment-13768770 ] Swapnil Ghike commented on KAFKA-1003: -- Created reviewb

[jira] [Commented] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

2013-09-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768771#comment-13768771 ] Swapnil Ghike commented on KAFKA-1003: -- Created reviewb

[jira] [Updated] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

2013-09-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1003: - Attachment: (was: KAFKA-1003_2013-09-16_14:13:04.patch) > ConsumerFetcherManager sho

[jira] [Updated] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

2013-09-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1003: - Attachment: KAFKA-1003.patch > ConsumerFetcherManager should pass clientId as metricsPre

[jira] [Updated] (KAFKA-42) Support rebalancing the partitions with replication

2013-09-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-42: --- Attachment: (was: KAFKA-42.patch) > Support rebalancing the partitions with replicat

[jira] [Commented] (KAFKA-42) Support rebalancing the partitions with replication

2013-09-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768747#comment-13768747 ] Swapnil Ghike commented on KAFKA-42: Created reviewboard >

[jira] [Updated] (KAFKA-42) Support rebalancing the partitions with replication

2013-09-16 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-42: --- Attachment: KAFKA-42.patch > Support rebalancing the partitions with replicat

  1   2   3   4   5   >