[jira] [Commented] (KAFKA-1667) topic-level configuration not validated

2014-11-25 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224394#comment-14224394 ] Dmytro Kostiuchenko commented on KAFKA-1667: Updated reviewboard h

[jira] [Updated] (KAFKA-1667) topic-level configuration not validated

2014-11-25 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kostiuchenko updated KAFKA-1667: --- Attachment: KAFKA-1667_2014-11-25_12:03:56.patch > topic-level configuration

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-25 Thread Dmytro Kostiuchenko
53ea10c5f > core/src/test/scala/kafka/log/LogConfigTest.scala PRE-CREATION > core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala > f44568cb25edf25db857415119018fd4c9922f61 > > Diff: https://reviews.apache.org/r/27634/diff/ > > > Testing > --- > > > Thanks, > > Dmytro Kostiuchenko > >

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-25 Thread Dmytro Kostiuchenko
/kafka/log/LogConfigTest.scala PRE-CREATION core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala f44568cb25edf25db857415119018fd4c9922f61 Diff: https://reviews.apache.org/r/27634/diff/ Testing --- Thanks, Dmytro Kostiuchenko

[jira] [Updated] (KAFKA-1667) topic-level configuration not validated

2014-11-16 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kostiuchenko updated KAFKA-1667: --- Attachment: KAFKA-1667_2014-11-16_18:33:10.patch > topic-level configuration

[jira] [Commented] (KAFKA-1667) topic-level configuration not validated

2014-11-16 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213978#comment-14213978 ] Dmytro Kostiuchenko commented on KAFKA-1667: Updated reviewboard h

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-16 Thread Dmytro Kostiuchenko
o bother anyway. So, I would leave it as it is. Please confirm that renaming to overridesAndDefaults is necessary and I will do that. - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.a

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-16 Thread Dmytro Kostiuchenko
/kafka/log/LogConfigTest.scala PRE-CREATION core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala f44568cb25edf25db857415119018fd4c9922f61 Diff: https://reviews.apache.org/r/27634/diff/ Testing --- Thanks, Dmytro Kostiuchenko

[jira] [Commented] (KAFKA-1667) topic-level configuration not validated

2014-11-16 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213977#comment-14213977 ] Dmytro Kostiuchenko commented on KAFKA-1667: Updated reviewboard h

[jira] [Updated] (KAFKA-1667) topic-level configuration not validated

2014-11-16 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kostiuchenko updated KAFKA-1667: --- Attachment: KAFKA-1667_2014-11-16_18:31:34.patch > topic-level configuration

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-16 Thread Dmytro Kostiuchenko
/test/scala/kafka/log/LogConfigTest.scala PRE-CREATION core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala f44568cb25edf25db857415119018fd4c9922f61 Diff: https://reviews.apache.org/r/27634/diff/ Testing --- Thanks, Dmytro Kostiuchenko

[jira] [Commented] (KAFKA-1667) topic-level configuration not validated

2014-11-14 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14212477#comment-14212477 ] Dmytro Kostiuchenko commented on KAFKA-1667: Bump. Anyone willing to re

[jira] [Updated] (KAFKA-1667) topic-level configuration not validated

2014-11-12 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kostiuchenko updated KAFKA-1667: --- Attachment: (was: KAFKA-1667.patch) > topic-level configuration not valida

[jira] [Updated] (KAFKA-1667) topic-level configuration not validated

2014-11-12 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kostiuchenko updated KAFKA-1667: --- Status: Patch Available (was: Open) > topic-level configuration not valida

[jira] [Commented] (KAFKA-1667) topic-level configuration not validated

2014-11-12 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207968#comment-14207968 ] Dmytro Kostiuchenko commented on KAFKA-1667: Can't assign issue

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-12 Thread Dmytro Kostiuchenko
-CREATION core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala f44568cb25edf25db857415119018fd4c9922f61 Diff: https://reviews.apache.org/r/27634/diff/ Testing --- Thanks, Dmytro Kostiuchenko

[jira] [Updated] (KAFKA-1667) topic-level configuration not validated

2014-11-12 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kostiuchenko updated KAFKA-1667: --- Attachment: KAFKA-1667_2014-11-12_12:49:11.patch > topic-level configuration

[jira] [Commented] (KAFKA-1667) topic-level configuration not validated

2014-11-12 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207957#comment-14207957 ] Dmytro Kostiuchenko commented on KAFKA-1667: Updated reviewboard h

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-11 Thread Dmytro Kostiuchenko
ould evaluate to "false", right? Why do we need > > "nottrue"? > > > > If String.valueOf(false) no longer works as expected, it looks like a > > bug waiting to happen... > > Dmytro Kostiuchenko wrote: > Before my changes boolean

[jira] [Updated] (KAFKA-1667) topic-level configuration not validated

2014-11-07 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kostiuchenko updated KAFKA-1667: --- Attachment: KAFKA-1667_2014-11-07_14:28:14.patch > topic-level configuration

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-07 Thread Dmytro Kostiuchenko
/UncleanLeaderElectionTest.scala f44568cb25edf25db857415119018fd4c9922f61 Diff: https://reviews.apache.org/r/27634/diff/ Testing --- Thanks, Dmytro Kostiuchenko

[jira] [Commented] (KAFKA-1667) topic-level configuration not validated

2014-11-07 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202026#comment-14202026 ] Dmytro Kostiuchenko commented on KAFKA-1667: Updated reviewboard h

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-07 Thread Dmytro Kostiuchenko
a2cc072f4db4ce014b63d226431d3766bef1 > core/src/main/scala/kafka/admin/TopicCommand.scala > 0b2735e7fc42ef9894bef1997b1f06a8ebee5439 > core/src/main/scala/kafka/log/LogConfig.scala > e48922a97727dd0b98f3ae630ebb0af3bef2373d > core/src/main/scala/kafka/utils/Utils.scala > 23aefb4715b177feae1d2f83e8b910653ea10c5f > core/src/test/scala/kafka/log/LogConfigTest.scala PRE-CREATION > core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala > f44568cb25edf25db857415119018fd4c9922f61 > > Diff: https://reviews.apache.org/r/27634/diff/ > > > Testing > --- > > > Thanks, > > Dmytro Kostiuchenko > >

[jira] [Commented] (KAFKA-1667) topic-level configuration not validated

2014-11-06 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200381#comment-14200381 ] Dmytro Kostiuchenko commented on KAFKA-1667: The main issue with the

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-06 Thread Dmytro Kostiuchenko
: https://reviews.apache.org/r/27634/diff/ Testing --- Thanks, Dmytro Kostiuchenko

[jira] [Commented] (KAFKA-1667) topic-level configuration not validated

2014-11-06 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200370#comment-14200370 ] Dmytro Kostiuchenko commented on KAFKA-1667: Updated reviewboard h

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-06 Thread Dmytro Kostiuchenko
Diff: https://reviews.apache.org/r/27634/diff/ Testing --- Thanks, Dmytro Kostiuchenko

[jira] [Updated] (KAFKA-1667) topic-level configuration not validated

2014-11-06 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kostiuchenko updated KAFKA-1667: --- Attachment: KAFKA-1667_2014-11-06_17:10:14.patch > topic-level configuration

[jira] [Commented] (KAFKA-1667) topic-level configuration not validated

2014-11-05 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198829#comment-14198829 ] Dmytro Kostiuchenko commented on KAFKA-1667: Updated reviewboard h

[jira] [Updated] (KAFKA-1667) topic-level configuration not validated

2014-11-05 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kostiuchenko updated KAFKA-1667: --- Attachment: KAFKA-1667_2014-11-05_19:43:53.patch > topic-level configuration

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-05 Thread Dmytro Kostiuchenko
/scala/kafka/admin/TopicCommand.scala 0b2735e7fc42ef9894bef1997b1f06a8ebee5439 core/src/main/scala/kafka/log/LogConfig.scala e48922a97727dd0b98f3ae630ebb0af3bef2373d Diff: https://reviews.apache.org/r/27634/diff/ Testing --- Thanks, Dmytro Kostiuchenko

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-05 Thread Dmytro Kostiuchenko
/admin/TopicCommand.scala 0b2735e7fc42ef9894bef1997b1f06a8ebee5439 core/src/main/scala/kafka/log/LogConfig.scala e48922a97727dd0b98f3ae630ebb0af3bef2373d Diff: https://reviews.apache.org/r/27634/diff/ Testing --- Thanks, Dmytro Kostiuchenko

Review Request 27634: Patch for KAFKA-1667

2014-11-05 Thread Dmytro Kostiuchenko
0b2735e7fc42ef9894bef1997b1f06a8ebee5439 core/src/main/scala/kafka/log/LogConfig.scala e48922a97727dd0b98f3ae630ebb0af3bef2373d Diff: https://reviews.apache.org/r/27634/diff/ Testing --- Thanks, Dmytro Kostiuchenko

[jira] [Comment Edited] (KAFKA-1667) topic-level configuration not validated

2014-11-05 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198638#comment-14198638 ] Dmytro Kostiuchenko edited comment on KAFKA-1667 at 11/5/14 5:0

[jira] [Issue Comment Deleted] (KAFKA-1667) topic-level configuration not validated

2014-11-05 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kostiuchenko updated KAFKA-1667: --- Comment: was deleted (was: As suggested on mailing list, moving discussion to JIRA

[jira] [Updated] (KAFKA-1667) topic-level configuration not validated

2014-11-05 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kostiuchenko updated KAFKA-1667: --- Attachment: KAFKA-1667.patch Initial patch with 3 TODOs to resolve > topic-le

[jira] [Commented] (KAFKA-1667) topic-level configuration not validated

2014-11-05 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198637#comment-14198637 ] Dmytro Kostiuchenko commented on KAFKA-1667: As suggested on mailing

KAFKA-1667 guidance required

2014-11-05 Thread Dmytro Kostiuchenko
Hi, I decided to fix KAFKA-1667. Currently I have an initial patch, which seems to work. I would like to know, whether overall code is ok. Also there are few TODOs in the code 1. I haven't added documentation to the properties, as ConfigDef suggests. Should I? 2. I'm not sure what Importance shou

[jira] [Commented] (KAFKA-1667) topic-level configuration not validated

2014-11-05 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198212#comment-14198212 ] Dmytro Kostiuchenko commented on KAFKA-1667: Hi. I'm willing to wor