[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198638#comment-14198638
]
Dmytro Kostiuchenko edited comment on KAFKA-1667 at 11/5/14 5:04 PM:
---------------------------------------------------------------------
So, I decided to just add validation and to impact as little as possible.
There is a new method in {{ConfigDef}}, which is needed to avoid duplication in
LogConfig (instead of maintaining ConfigNames we derive them from configDef)
All properties are now of MEDIUM importance and have no documentation.
All numeric values are required to be >0, compact property validated against
set ["compact", "delete"].
I would appreciate if you take a look on the patch and suggest, whether it is
ok to submit it as a fix.
P.S. sorry for my megaverbosity. That's my first contribution
was (Author: edio):
Initial patch with 3 TODOs to resolve
> topic-level configuration not validated
> ----------------------------------------
>
> Key: KAFKA-1667
> URL: https://issues.apache.org/jira/browse/KAFKA-1667
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8.1.1
> Reporter: Ryan Berdeen
> Labels: newbie
> Attachments: KAFKA-1667.patch
>
>
> I was able to set the configuration for a topic to these invalid values:
> {code}
> Topic:topic-config-test PartitionCount:1 ReplicationFactor:2
> Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
> {code}
> It seems that the values are saved as long as they are the correct type, but
> are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
