[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200381#comment-14200381
]
Dmytro Kostiuchenko commented on KAFKA-1667:
--------------------------------------------
The main issue with the old patch was handling {{Properties}} defaults.
When properties were passed to {{fromProps(Properties)}} method, {{Properties}}
object has been exposed as a {{Map}}. {{Map.get()}}, though is implemented in
{{Hashtable}} and thus knows nothing about {{Properties}} defaults. Fixed that,
added few trivial tests to check general correctness.
There is an impact on the client code though: boolean values are now parsed via
{{Boolean.parseBoolean}} throwing no exception but instead falling back to
{{false}} for invalid input.
> topic-level configuration not validated
> ----------------------------------------
>
> Key: KAFKA-1667
> URL: https://issues.apache.org/jira/browse/KAFKA-1667
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8.1.1
> Reporter: Ryan Berdeen
> Labels: newbie
> Attachments: KAFKA-1667.patch, KAFKA-1667_2014-11-05_19:43:53.patch,
> KAFKA-1667_2014-11-06_17:10:14.patch
>
>
> I was able to set the configuration for a topic to these invalid values:
> {code}
> Topic:topic-config-test PartitionCount:1 ReplicationFactor:2
> Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
> {code}
> It seems that the values are saved as long as they are the correct type, but
> are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
