Build failed in Jenkins: kafka-trunk-jdk8 #3155

2018-10-22 Thread Apache Jenkins Server
See Changes: [mjsax] MINOR: Prohibit setting StreamsConfig commit.interval.ms to a negative -- [...truncated 2.83 MB...] org.apache.kafka.streams.test.OutputVerifierTest

Build failed in Jenkins: kafka-1.1-jdk7 #223

2018-10-22 Thread Apache Jenkins Server
See Changes: [junrao] KAFKA-7299: Batch LeaderAndIsr requests for AutoLeaderRebalance (#5515) -- [...truncated 425.68 KB...] kafka.server.epoch.LeaderEpochFileCacheTest > sh

Re: [DISCUSS] KIP-386: Make Min metrics' default value consistent with Max metrics

2018-10-22 Thread John Roesler
Hi Stanislav, Thanks for this KIP. I coincidentally just noticed these strange initial values while doing some performance measurements. Since the metric type is a double, could we consider NaN instead? It seems like +Inf is somewhat arbitrary for Max, so it might as well be an arbitrary value tha

Re: [DISCUSS] KIP-377: TopicCommand to use AdminClient

2018-10-22 Thread Kevin Lu
Hi Viktor, +1 to this KIP. I would very much like to see AdminClient in TopicCommand. This would also allow us to efficiently implement new features like the "--under-min-isr" option I proposed in KIP-351

Re: [DISCUSS] KIP-351: Add --under-min-isr option to describe topics command

2018-10-22 Thread Kevin Lu
Hi Mickael, Thanks for the suggestion for getting the "computed" configuration from AdminClient.describeConfigs(). That's exactly what I was looking for! I have updated the KIP to use AdminClient.describeConfigs(), and included a code snippet. Please take a look. Since KIP-377 proposes the same

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

2018-10-22 Thread Jun Rao
Hi, Patrick, Yes, that's the general sequence. After step 2, the shutting down broker can give up the controlled shutdown process and proceed to shut down. When it's restarted, it could still receive StopReplica requests from the controller in reaction to the previous controlled shutdown requests.

RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-22 Thread Pellerin, Clement
If it is up to me, I'd say the KIP is now finalized. Can I call for a [VOTE] or I need more feedback? -Original Message- From: Harsha Chintalapani [mailto:ka...@harsha.io] Sent: Monday, October 22, 2018 4:36 PM To: dev@kafka.apache.org Subject: RE: [DISCUSS] KIP-383 Pluggable interface f

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

2018-10-22 Thread Patrick Huang
Hi Jun, That is a good point. I want to make it clear about the scenario you mentioned. Correct me if I am wrong. Here is the sequence of the event: 1. Broker sends ControlledShutdown request 1 to controller 2. Broker sends ControlledShutdown request 2 to controller due to reties 3. Con

[jira] [Created] (KAFKA-7530) Need to allow overwrite ssl.endpoint.identification.algorithm.config

2018-10-22 Thread Sophie Qian (JIRA)
Sophie Qian created KAFKA-7530: -- Summary: Need to allow overwrite ssl.endpoint.identification.algorithm.config Key: KAFKA-7530 URL: https://issues.apache.org/jira/browse/KAFKA-7530 Project: Kafka

kafka design patterns

2018-10-22 Thread abeceda4
Hi can you help me identify design patterns in the code apache/kafka ? Thanks   Mrkvica

RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-22 Thread Harsha Chintalapani
Thanks for the changes. KIP looks good to me. -Harsha On Oct 22, 2018, 12:57 PM -0700, Pellerin, Clement , wrote: > I updated the KIP. The proposed interface is now named SslFactory and the > default implementation is DefaultSslFactory. > I also mention the existing non-default constructors will

RE: [DISCUSS] KIP-383 Pluggable interface for SSL Factory

2018-10-22 Thread Pellerin, Clement
I updated the KIP. The proposed interface is now named SslFactory and the default implementation is DefaultSslFactory. I also mention the existing non-default constructors will be removed. The constants for the new config keys are now declared in the interface itself. Please give me your feedback

Re: [DISCUSS] KIP-386: Make Min metrics' default value consistent with Max metrics

2018-10-22 Thread Stanislav Kozlovski
Hi Suman, Thanks for taking a look at this. Yeah, it's very minor but it changes the public API (even if this is a very slight change) and as far as I know this warrants some discussion On Mon, Oct 22, 2018 at 9:28 PM Suman B N wrote: > Looks good to me. Maintains uniformity. +1 from me. > But

Re: [DISCUSS] KIP-386: Make Min metrics' default value consistent with Max metrics

2018-10-22 Thread Suman B N
Looks good to me. Maintains uniformity. +1 from me. But its more of a bug rather than improvement proposal. Let's see what contributors got to say. On Mon, Oct 22, 2018 at 7:23 PM Stanislav Kozlovski wrote: > Hey everybody, > > I've opened up a very short KIP to make the Max and Min metrics' def

[jira] [Created] (KAFKA-7529) Kafka Connect JDBC doesn't push new records to Kafka Topic unless the connector is restarted

2018-10-22 Thread Kashyap Ivaturi (JIRA)
Kashyap Ivaturi created KAFKA-7529: -- Summary: Kafka Connect JDBC doesn't push new records to Kafka Topic unless the connector is restarted Key: KAFKA-7529 URL: https://issues.apache.org/jira/browse/KAFKA-7529

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

2018-10-22 Thread Jun Rao
Hi, Patrick, There is another thing that may be worth considering. 10. It will be useful to include the czxid also in the ControlledShutdown request. This way, if the broker has been restarted, the controller can ignore an old ControlledShutdown request(e.g., due to retries). This will prevent th

KAFKA-3932 - Consumer fails to consume in a round robin fashion

2018-10-22 Thread ChienHsing Wu
Hi, I encountered the issue documented in the jira KAFKA-3932. Upon studying the source code and the PIP, I t

Re: request wiki permissions

2018-10-22 Thread Jun Rao
Clement, Thanks for your interest. Just gave you the permission. Jun On Mon, Oct 22, 2018 at 10:00 AM, Pellerin, Clement < clement_pelle...@ibi.com> wrote: > Can you give wiki permissions to wiki ID cpellerin? > I was able to create and edit KIP-383 last week but it no longer works for > me. >

request wiki permissions

2018-10-22 Thread Pellerin, Clement
Can you give wiki permissions to wiki ID cpellerin? I was able to create and edit KIP-383 last week but it no longer works for me.

Build failed in Jenkins: kafka-trunk-jdk8 #3154

2018-10-22 Thread Apache Jenkins Server
See Changes: [ismael] KAFKA-7519 Clear pending transaction state when expiration fails (#5820) -- [...truncated 2.83 MB...] org.apache.kafka.streams.test.OutputVerifierTe

Build failed in Jenkins: kafka-2.1-jdk8 #37

2018-10-22 Thread Apache Jenkins Server
See Changes: [ismael] KAFKA-7519 Clear pending transaction state when expiration fails (#5820) -- [...truncated 427.96 KB...] kafka.admin.PreferredReplicaElectionCommandTest

[DISCUSS] KIP-386: Make Min metrics' default value consistent with Max metrics

2018-10-22 Thread Stanislav Kozlovski
Hey everybody, I've opened up a very short KIP to make the Max and Min metrics' default values consistent with each other. KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-386%3A+Make+Min+metrics%27+default+value+consistent+with+Max+metrics JIRA: https://issues.apache.org/jira/browse/KA

[jira] [Created] (KAFKA-7528) Make Min and Max metrics' default value consistent with each other

2018-10-22 Thread Stanislav Kozlovski (JIRA)
Stanislav Kozlovski created KAFKA-7528: -- Summary: Make Min and Max metrics' default value consistent with each other Key: KAFKA-7528 URL: https://issues.apache.org/jira/browse/KAFKA-7528 Project:

Jenkins build is back to normal : kafka-trunk-jdk8 #3153

2018-10-22 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-351: Add --under-min-isr option to describe topics command

2018-10-22 Thread Mickael Maison
It might be worth syncing with KIP-377 which is already planning to make TopicCommand use the AdminClient and add a --bootstrap-server argument. Also in the proposed changes section, you mention the challenge of finding the topic min ISR configuration. Using the AdminClient.describeConfigs() API,

Build failed in Jenkins: kafka-2.1-jdk8 #36

2018-10-22 Thread Apache Jenkins Server
See Changes: [ismael] KAFKA-7501: Fix producer batch double deallocation when receiving -- [...truncated 182.80 KB...] kafka.api.AuthorizerIntegrationTest > testIdempotentPro

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

2018-10-22 Thread Damian Guy
Thanks +1 binding On Sun, 7 Oct 2018 at 03:16, Chia-Ping Tsai wrote: > (just bump) > > We have following votes: > > non-binding > 1. John Roesler > 2. vito jeng > 3. Richard Yu > 4. Bill Bejeck > 5. Satish Duggana > > binding > 1. Matthias J. Sax > 2. Ismael Juma > > it needs one more ticket :)

Re: [DISCUSS] KIP-280: Enhanced log compaction

2018-10-22 Thread Luís Cabral
Since this is not moving forward, how about I proceed with the currently documented changes, and any improvements (such as configuration changes) can be taken up afterwards by whoever wants it under a different KIP? On Thursday, October 11, 2018, 9:47:12 AM GMT+2, Luís Cabral wrote: