It might be worth syncing with KIP-377 which is already planning to make TopicCommand use the AdminClient and add a --bootstrap-server argument.
Also in the proposed changes section, you mention the challenge of finding the topic min ISR configuration. Using the AdminClient.describeConfigs() API, you directly get the "computed" configuration for topics. If the topic is using the default config from the broker the configuration source will be set to "DEFAULT_CONFIG". In case, the configuration was specified during creation, the source will be set to "DYNAMIC_TOPIC_CONFIG". So there's no need to query Zookeeper. On Fri, Oct 19, 2018 at 5:02 PM Kevin Lu <lu.ke...@berkeley.edu> wrote: > > Bumping this as I have added some additional details. > > This change will require adding a "--bootstrap-server" flag to identify the > current broker/cluster configured "min.insync.replicas". > > Regards, > Kevin > > On Fri, Oct 12, 2018 at 4:19 PM Kevin Lu <lu.ke...@berkeley.edu> wrote: > > > Hi All, > > > > After some feedback, I have reformulated KIP-351 > > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-351%3A+Add+--under-min-isr+option+to+describe+topics+command> > > . > > > > This KIP proposes an additional "--under-min-isr" option in TopicCommand > > to show topic partitions which are under the configured > > "min.insync.replicas" to help operators identify which topic partitions > > need immediate fixing. > > > > Please take a look and provide some feedback! > > > > Thanks! > > > > Regards, > > Kevin > >
