Hi Suman, Thanks for taking a look at this. Yeah, it's very minor but it changes the public API (even if this is a very slight change) and as far as I know this warrants some discussion
On Mon, Oct 22, 2018 at 9:28 PM Suman B N <sumannew...@gmail.com> wrote: > Looks good to me. Maintains uniformity. +1 from me. > But its more of a bug rather than improvement proposal. Let's see what > contributors got to say. > > On Mon, Oct 22, 2018 at 7:23 PM Stanislav Kozlovski < > stanis...@confluent.io> > wrote: > > > Hey everybody, > > > > I've opened up a very short KIP to make the Max and Min metrics' default > > values consistent with each other. > > > > KIP: > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-386%3A+Make+Min+metrics%27+default+value+consistent+with+Max+metrics > > JIRA: https://issues.apache.org/jira/browse/KAFKA-7528 > > > > This is hopefully a very straightforward change. Please provide feedback. > > Thanks > > > > -- > > Best, > > Stanislav > > > > > -- > *Suman* > *OlaCabs* > -- Best, Stanislav
